From mboxrd@z Thu Jan 1 00:00:00 1970 From: mporter@linaro.org (Matt Porter) Date: Tue, 11 Mar 2014 11:50:54 -0400 Subject: [PATCH v2 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap In-Reply-To: <20140219044458.GA2669@sirena.org.uk> References: <1392765432-9111-1-git-send-email-mporter@linaro.org> <1392765432-9111-6-git-send-email-mporter@linaro.org> <20140219044458.GA2669@sirena.org.uk> Message-ID: <20140311155054.GL25092@beef> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 19, 2014 at 01:44:58PM +0900, Mark Brown wrote: > On Tue, Feb 18, 2014 at 06:17:12PM -0500, Matt Porter wrote: > > > + csr_reg: regulator at 13 { > > + reg = <13>; > > + regulator-compatible = "csr"; > > + regulator-min-microvolt = <860000>; > > + regulator-max-microvolt = <1440000>; > > + }; > > You should not be setting voltage ranges like this in a .dtsi - you've > no idea if these voltage ranges are in fact valid for any given board so > they can't be set safely. In general I would not expect to see any > configuration at all for regulators in an include file for the chip. Agreed. I moved all constraints where they belong in the board-specific dts. Thanks, Matt -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: