From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] mfd: add bcm590xx pmu driver
Date: Tue, 11 Mar 2014 18:19:38 -0400 [thread overview]
Message-ID: <20140311221938.GO25092@beef> (raw)
In-Reply-To: <20140311160837.GP21216@lee--X1>
On Tue, Mar 11, 2014 at 04:08:37PM +0000, Lee Jones wrote:
> > Add a driver for the BCM590xx PMU multi-function devices. The driver
> > initially supports regmap initialization and instantiation of the
> > voltage regulator device function of the PMU.
> >
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> > Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> > ---
> > drivers/mfd/Kconfig | 8 ++++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++
> > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++
> > 4 files changed, 133 insertions(+)
> > create mode 100644 drivers/mfd/bcm590xx.c
> > create mode 100644 include/linux/mfd/bcm590xx.h
>
> I have a tiny nit that 'ret' doesn't need to be initialised before
> use in probe(), but apart from that...
>
> Looks pretty sensible:
> Acked-by: Lee Jones <lee.jones@linaro.org>
Ok, thanks. When I get back in front of my desktop I'll send a v4 of
just this patch to address that nit. Mark already applied the regulator
driver from this series, will you be taking this through your tree? For
that matter, I wonder if the binding would also go through your tree
with this driver.
-Matt
next prev parent reply other threads:[~2014-03-11 22:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 15:46 [PATCH v3 0/5] BCM59056 PMU regulator support Matt Porter
2014-03-11 15:46 ` [PATCH v3 1/5] mfd: add bcm590xx pmu DT binding Matt Porter
2014-03-11 15:46 ` [PATCH v3 2/5] mfd: add bcm590xx pmu driver Matt Porter
2014-03-11 16:08 ` Lee Jones
2014-03-11 22:19 ` Matt Porter [this message]
2014-03-11 22:45 ` Lee Jones
2014-03-11 23:25 ` Matt Porter
2014-03-12 0:40 ` Mark Brown
2014-03-12 0:57 ` Matt Porter
2014-03-12 9:23 ` Lee Jones
2014-03-12 9:35 ` Lee Jones
2014-03-11 15:46 ` [PATCH v3 3/5] regulator: add bcm590xx regulator driver Matt Porter
2014-03-11 18:52 ` Mark Brown
2014-03-11 15:46 ` [PATCH v3 4/5] ARM: configs: bcm_defconfig: enable bcm590xx regulator support Matt Porter
2014-03-11 15:46 ` [PATCH v3 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311221938.GO25092@beef \
--to=mporter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).