[PATCH v3 2/5] mfd: add bcm590xx pmu driver

Lee Jones
2014-03-11T16:08:37Z

> Add a driver for the BCM590xx PMU multi-function devices. The driver
> initially supports regmap initialization and instantiation of the
> voltage regulator device function of the PMU.
>
> Signed-off-by: Matt Porter <mporter@linaro.org>
> Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> ---
> drivers/mfd/Kconfig | 8 ++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/bcm590xx.h | 31 +++++++++++++++
> 4 files changed, 133 insertions(+)
> create mode 100644 drivers/mfd/bcm590xx.c
> create mode 100644 include/linux/mfd/bcm590xx.h

I have a tiny nit that 'ret' doesn't need to be initialised before
use in probe(), but apart from that...

Looks pretty sensible:
Acked-by: Lee Jones <lee.jones@linaro.org>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog