[PATCH v3 2/5] mfd: add bcm590xx pmu driver

Matt Porter
2014-03-11T22:19:38Z

On Tue, Mar 11, 2014 at 04:08:37PM +0000, Lee Jones wrote:
> > Add a driver for the BCM590xx PMU multi-function devices. The driver
> > initially supports regmap initialization and instantiation of the
> > voltage regulator device function of the PMU.
> >
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> > Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> > ---
> > drivers/mfd/Kconfig | 8 ++++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++
> > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++
> > 4 files changed, 133 insertions(+)
> > create mode 100644 drivers/mfd/bcm590xx.c
> > create mode 100644 include/linux/mfd/bcm590xx.h
>
> I have a tiny nit that 'ret' doesn't need to be initialised before
> use in probe(), but apart from that...
>
> Looks pretty sensible:
> Acked-by: Lee Jones <lee.jones@linaro.org>

Ok, thanks. When I get back in front of my desktop I'll send a v4 of
just this patch to address that nit. Mark already applied the regulator
driver from this series, will you be taking this through your tree? For
that matter, I wonder if the binding would also go through your tree
with this driver.

-Matt