linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/5] mfd: add bcm590xx pmu DT binding
Date: Wed, 12 Mar 2014 09:46:34 -0400	[thread overview]
Message-ID: <20140312134634.GR25092@beef> (raw)
In-Reply-To: <20140312133339.GC17461@e106331-lin.cambridge.arm.com>

On Wed, Mar 12, 2014 at 01:33:39PM +0000, Mark Rutland wrote:
> On Tue, Mar 11, 2014 at 11:33:53PM +0000, Matt Porter wrote:
> > Add a DT binding for the BCM590xx PMUs. The binding inherits from
> > the generic regulator bindings.
> > 
> > Signed-off-by: Matt Porter <mporter@linaro.org>
> > Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> > Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/bcm590xx.txt | 41 ++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/bcm590xx.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/bcm590xx.txt b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
> > new file mode 100644
> > index 0000000..2300246
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/bcm590xx.txt
> > @@ -0,0 +1,41 @@
> > +-------------------------------
> > +BCM590xx Power Management Units
> > +-------------------------------
> > +
> > +Required properties:
> > +- compatible: "brcm,bcm59056"
> > +- reg: I2C slave address
> > +- interrupts: interrupt for the PMU. Generic interrupt client node bindings
> > +  are described in interrupt-controller/interrupts.txt
> 
> This all looks sane.
> 
> > +
> > +------------------
> > +Voltage Regulators
> > +------------------
> > +
> > +Optional properties:
> > +- regulators: This is the list of child nodes that specify the regulator
> > +  initialization data for defined regulators.  Generic regulator bindings
> > +  are described in regulator/regulator.txt.
> 
> This is a subnode, not a property. How about:
> 
> Optional child nodes:
> 
> - regulators: container node for regulators follwoing the generic
>   regulator binding in regulator/regulator.txt.

Agreed, I'll reword like that...makes more sense like that.

> > +
> > +  The valid regulator nodes for BCM59056 are:
> 
> s/nodes/node names/

Ok

> > +  	rfldo, camldo1, camldo2, simldo1, simldo2, sdldo, sdxldo,
> > +	mmcldo1, mmcldo2, audldo, micldo, usbldo, vibldo,
> > +	csr, iosr1, iosr2, msr, sdsr1, sdsr2, vsr
> > +
> > +Example:
> > +	pmu: bcm59056 at 8 {
> > +		compatible = "brcm,bcm59056";
> > +		reg = <0x08>;
> > +		interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
> > +		regulators {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			rfldo_reg: rfldo {
> > +				regulator-min-microvolt = <1200000>;
> > +				regulator-max-microvolt = <3300000>;
> 
> Are any specific properties required on these children?

None. The only requirement is that when regulator node exists, the
node names must match those listed.

I'll send out another version with rewording suggested above.

Thanks,
Matt

  parent reply	other threads:[~2014-03-12 13:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 23:33 [PATCH v4 0/5] BCM59056 PMU regulator support Matt Porter
2014-03-11 23:33 ` [PATCH v4 1/5] mfd: add bcm590xx pmu DT binding Matt Porter
2014-03-12 13:33   ` Mark Rutland
2014-03-12 13:45     ` Mark Brown
2014-03-12 13:46     ` Matt Porter [this message]
2014-03-11 23:33 ` [PATCH v4 2/5] mfd: add bcm590xx pmu driver Matt Porter
2014-03-12  9:46   ` Lee Jones
2014-03-11 23:33 ` [PATCH v4 3/5] regulator: add bcm590xx regulator driver Matt Porter
2014-03-11 23:33 ` [PATCH v4 4/5] ARM: configs: bcm_defconfig: enable bcm590xx regulator support Matt Porter
2014-03-11 23:33 ` [PATCH v4 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140312134634.GR25092@beef \
    --to=mporter@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).