From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] ARM: mvebu: Add support for NAND controller in Armada 38x SoC
Date: Wed, 12 Mar 2014 17:30:07 -0300 [thread overview]
Message-ID: <20140312203007.GA7396@arch.cereza> (raw)
In-Reply-To: <5320CEE7.6020506@cogentembedded.com>
On Mar 13, Sergei Shtylyov wrote:
> On 03/12/2014 06:16 PM, Ezequiel Garcia wrote:
>
> >The Armada 38x SoC family has a NAND controller, compatible
> >with the controller in Armada 370/375/XP SoCs. Add support for
> >it in the devicetree file.
>
> >Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> >---
> > arch/arm/boot/dts/armada-38x.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
>
> >diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> >index 76cc27e..18d8f80 100644
> >--- a/arch/arm/boot/dts/armada-38x.dtsi
> >+++ b/arch/arm/boot/dts/armada-38x.dtsi
> >@@ -345,6 +345,16 @@
> > clocks = <&mainpll>;
> > clock-output-names = "nand";
> > };
> >+
> >+ nand at d0000 {
>
> ePAPR standard [1] tells us:
>
> The name of a node should be somewhat generic, reflecting the function of
> the device and not its precise programming model. If appropriate, the name
> should be one of the following choices:
>
> [...]
> ? flash
>
I think 'nand' is generic enough, isn't it?
In any case, it seems sane to distinguish a NAND flash from a NOR flash,
from a SPI flash.
FWIW, quite a few other SoCs have chosen 'nand' for the node name, including
the other Armada variants. Was this a wrong choice?
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-12 20:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 15:16 [PATCH 0/6] Armada 380 NAND support Ezequiel Garcia
2014-03-12 15:16 ` [PATCH 1/6] clk: mvebu: Support Armada 380 SoC on the core divider clock Ezequiel Garcia
2014-03-12 15:16 ` [PATCH 2/6] ARM: mvebu: Add a 2 GHz fixed-clock on Armada 38x SoCs Ezequiel Garcia
2014-03-12 15:16 ` [PATCH 3/6] ARM: mvebu: Add the Core Divider clock to " Ezequiel Garcia
2014-03-12 15:16 ` [PATCH 4/6] ARM: mvebu: Add support for NAND controller in Armada 38x SoC Ezequiel Garcia
2014-03-12 21:17 ` Sergei Shtylyov
2014-03-12 20:30 ` Ezequiel Garcia [this message]
2014-03-12 21:39 ` Sergei Shtylyov
2014-03-12 21:29 ` Ezequiel Garcia
2014-03-12 15:16 ` [PATCH 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB Ezequiel Garcia
2014-03-12 15:16 ` [PATCH 6/6] clk: mvebu: Update binding documentation for the core divider clock Ezequiel Garcia
2014-03-13 19:19 ` [PATCH 0/6] Armada 380 NAND support Jason Cooper
2014-03-13 19:25 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312203007.GA7396@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox