From: pratyush.anand@st.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: SPEAr1340: static-ize SATA functions
Date: Thu, 20 Mar 2014 14:25:09 +0530 [thread overview]
Message-ID: <20140320085509.GB4607@pratyush-vbox> (raw)
In-Reply-To: <CAOh2x=nr1mrkcFk8nQFwNXxCqMPiN1Hq4=f1wwN=i65StawJ1Q@mail.gmail.com>
On Tue, Mar 18, 2014 at 07:00:08PM +0800, Viresh Kumar wrote:
> On Tue, Mar 18, 2014 at 4:28 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> > Make sata_miphy_exit(), sata_suspend() and sata_resume() static.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > Previous submission:
> > https://lkml.org/lkml/2013/10/4/369
> >
> > arch/arm/mach-spear/spear1340.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-spear/spear1340.c b/arch/arm/mach-spear/spear1340.c
> > index 3fb6834..e0e4251 100644
> > --- a/arch/arm/mach-spear/spear1340.c
> > +++ b/arch/arm/mach-spear/spear1340.c
> > @@ -93,7 +93,7 @@ static int sata_miphy_init(struct device *dev, void __iomem *addr)
> > return 0;
> > }
> >
> > -void sata_miphy_exit(struct device *dev)
> > +static void sata_miphy_exit(struct device *dev)
> > {
> > writel(0, SPEAR1340_PCIE_SATA_CFG);
> > writel(0, SPEAR1340_PCIE_MIPHY_CFG);
> > @@ -107,7 +107,7 @@ void sata_miphy_exit(struct device *dev)
> > msleep(20);
> > }
> >
> > -int sata_suspend(struct device *dev)
> > +static int sata_suspend(struct device *dev)
> > {
> > if (dev->power.power_state.event == PM_EVENT_FREEZE)
> > return 0;
> > @@ -117,7 +117,7 @@ int sata_suspend(struct device *dev)
> > return 0;
> > }
> >
> > -int sata_resume(struct device *dev)
> > +static int sata_resume(struct device *dev)
> > {
> > if (dev->power.power_state.event == PM_EVENT_THAW)
> > return 0;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
This patch will not be needed any more, since sata platform code has
already been cleaned up.
See:
https://lkml.org/lkml/2014/2/28/174
Regards
Pratyush
prev parent reply other threads:[~2014-03-20 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 10:58 [PATCH RESEND] ARM: SPEAr1340: static-ize SATA functions Bartlomiej Zolnierkiewicz
2014-03-18 11:00 ` Viresh Kumar
2014-03-20 8:55 ` Pratyush Anand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320085509.GB4607@pratyush-vbox \
--to=pratyush.anand@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox