From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 6/9] ARM: shmobile: Add PCIe device tree nodes for R8A7790
Date: Fri, 21 Mar 2014 10:40:15 -0600 [thread overview]
Message-ID: <20140321164015.GA3374@obsidianresearch.com> (raw)
In-Reply-To: <6044873.2S2Xlhp0hC@wuerfel>
On Fri, Mar 21, 2014 at 03:57:25PM +0100, Arnd Bergmann wrote:
> On Friday 21 March 2014 14:53:48 Phil.Edworthy at renesas.com wrote:
> >
> > > > + reg = <0 0xfe000000 0 0x80000>;
> > > > + #address-cells = >;
> > > > + #size-cells = <2>;
> > > > + device_type = "pci";
> > >
> > > This legacy property is only meaningful for the true OF firmware and
> > thus
> > > have been phased out (it's only actively used for the memory nodes).
> > Ok, thanks for pointing this out.
> >
>
> I think the code still relies on it for PCI though.
Right, it must be present for PCI nodes, it triggers special behavior
in the address parsing routines.
What Phil has looks correct to me.
Regards,
Jason
next prev parent reply other threads:[~2014-03-21 16:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 10:32 [PATCH v4 0/9] R-Car Gen2 PCIe host driver Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 1/9] PCI: host: rcar: Add Renesas R-Car PCIe driver Phil Edworthy
2014-03-21 11:04 ` Arnd Bergmann
2014-03-21 13:59 ` Phil.Edworthy at renesas.com
2014-03-21 14:06 ` Ben Dooks
2014-03-21 15:07 ` Arnd Bergmann
2014-03-23 10:05 ` Geert Uytterhoeven
2014-03-21 10:32 ` [PATCH v4 2/9] PCI: host: rcar: Add MSI support Phil Edworthy
2014-03-21 11:17 ` Lucas Stach
2014-03-21 14:15 ` Phil.Edworthy at renesas.com
2014-03-21 14:26 ` Lucas Stach
2014-03-21 14:34 ` Phil.Edworthy at renesas.com
2014-03-21 10:32 ` [PATCH v4 3/9] ARM: shmobile: r8a7790: Add PCIe clock device tree nodes Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 4/9] ARM: shmobile: r8a7791: " Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 5/9] dt-bindings: pci: rcar pcie device tree bindings Phil Edworthy
2014-03-21 11:23 ` Lucas Stach
2014-03-21 14:18 ` Phil.Edworthy at renesas.com
2014-03-21 14:30 ` Lucas Stach
2014-03-21 15:02 ` Phil.Edworthy at renesas.com
[not found] ` <OFC7DD5DAC.D378B300-ON80257CA2.0051ECEE-80257CA2.00529F98@LocalDomain>
2014-03-24 12:04 ` Phil.Edworthy at renesas.com
2014-03-24 12:15 ` Ben Dooks
2014-03-24 12:25 ` Phil.Edworthy at renesas.com
[not found] ` <OF85DD7B1D.716DE42D-ON80257CA5.00443087-80257CA5.004447DB@LocalDomain>
2014-03-24 12:46 ` Phil.Edworthy at renesas.com
2014-03-24 12:53 ` Lucas Stach
2014-03-21 10:32 ` [PATCH v4 6/9] ARM: shmobile: Add PCIe device tree nodes for R8A7790 Phil Edworthy
2014-03-21 15:29 ` Sergei Shtylyov
2014-03-21 14:53 ` Phil.Edworthy at renesas.com
2014-03-21 14:57 ` Arnd Bergmann
2014-03-21 16:40 ` Jason Gunthorpe [this message]
2014-03-21 16:42 ` Sergei Shtylyov
2014-03-21 16:31 ` Phil.Edworthy at renesas.com
2014-03-21 16:49 ` Jason Gunthorpe
2014-03-23 10:13 ` Geert Uytterhoeven
2014-03-21 15:32 ` Sergei Shtylyov
2014-03-21 15:06 ` Phil.Edworthy at renesas.com
2014-03-21 10:32 ` [PATCH v4 7/9] ARM: shmobile: Add PCIe device tree nodes for R8A7791 Koelsch board Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 8/9] ARM: koelsch: Add PCIe to defconfig Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 9/9] ARM: koelsch: Add HAVE_ARM_ARCH_TIMER " Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321164015.GA3374@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).