* [PATCH 2/5] ARM: dts: tx53: sort the i2c subnodes by I2C address
2014-03-19 13:28 [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on Lothar Waßmann
@ 2014-03-19 13:28 ` Lothar Waßmann
2014-03-19 13:28 ` [PATCH 3/5] ARM: dts: tx53: fix LVDS display mappings Lothar Waßmann
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Lothar Waßmann @ 2014-03-19 13:28 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/imx53-tx53-x13x.dts | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index c8a3473..cd3476b 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -108,14 +108,6 @@
pinctrl-0 = <&pinctrl_i2c3>;
status = "okay";
- sgtl5000: codec at 0a {
- compatible = "fsl,sgtl5000";
- reg = <0x0a>;
- VDDA-supply = <®_2v5>;
- VDDIO-supply = <®_3v3>;
- clocks = <&mclk>;
- };
-
touchscreen1: eeti at 04 {
compatible = "eeti,egalax_ts";
reg = <0x04>;
@@ -126,6 +118,14 @@
wakeup-gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>;
linux,wakeup;
};
+
+ sgtl5000: codec at 0a {
+ compatible = "fsl,sgtl5000";
+ reg = <0x0a>;
+ VDDA-supply = <®_2v5>;
+ VDDIO-supply = <®_3v3>;
+ clocks = <&mclk>;
+ };
};
&iomuxc {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/5] ARM: dts: tx53: fix LVDS display mappings
2014-03-19 13:28 [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on Lothar Waßmann
2014-03-19 13:28 ` [PATCH 2/5] ARM: dts: tx53: sort the i2c subnodes by I2C address Lothar Waßmann
@ 2014-03-19 13:28 ` Lothar Waßmann
2014-03-19 13:28 ` [PATCH 4/5] ARM: dts: tx53: add simple-panel support Lothar Waßmann
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Lothar Waßmann @ 2014-03-19 13:28 UTC (permalink / raw)
To: linux-arm-kernel
The data-mapping and data-width settings were opposite of what the
display requires. Interestingly, these settings nevertheless produced
correct results.
Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/imx53-tx53-x13x.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index cd3476b..26b918e 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -181,8 +181,8 @@
status = "okay";
lvds0: lvds-channel at 0 {
- fsl,data-mapping = "jeida";
- fsl,data-width = <24>;
+ fsl,data-mapping = "spwg";
+ fsl,data-width = <18>;
status = "okay";
display-timings {
@@ -206,8 +206,8 @@
};
lvds1: lvds-channel at 1 {
- fsl,data-mapping = "jeida";
- fsl,data-width = <24>;
+ fsl,data-mapping = "spwg";
+ fsl,data-width = <18>;
status = "okay";
display-timings {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/5] ARM: dts: tx53: add simple-panel support
2014-03-19 13:28 [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on Lothar Waßmann
2014-03-19 13:28 ` [PATCH 2/5] ARM: dts: tx53: sort the i2c subnodes by I2C address Lothar Waßmann
2014-03-19 13:28 ` [PATCH 3/5] ARM: dts: tx53: fix LVDS display mappings Lothar Waßmann
@ 2014-03-19 13:28 ` Lothar Waßmann
2014-03-22 6:46 ` Shawn Guo
2014-03-19 13:28 ` [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints Lothar Waßmann
2014-03-22 6:47 ` [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on Shawn Guo
4 siblings, 1 reply; 11+ messages in thread
From: Lothar Waßmann @ 2014-03-19 13:28 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/imx53-tx53-x13x.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
index 26b918e..86a964d 100644
--- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
@@ -63,6 +63,18 @@
default-brightness-level = <50>;
};
+ panel0 {
+ compatible = "simple-panel";
+ power-supply = <®_lcd_pwr0>;
+ backlight = <&backlight0>;
+ };
+
+ panel1 {
+ compatible = "simple-panel";
+ power-supply = <®_lcd_pwr1>;
+ backlight = <&backlight1>;
+ };
+
regulators {
reg_lcd_pwr0: regulator at 5 {
compatible = "regulator-fixed";
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/5] ARM: dts: tx53: add simple-panel support
2014-03-19 13:28 ` [PATCH 4/5] ARM: dts: tx53: add simple-panel support Lothar Waßmann
@ 2014-03-22 6:46 ` Shawn Guo
2014-03-25 13:14 ` Lothar Waßmann
0 siblings, 1 reply; 11+ messages in thread
From: Shawn Guo @ 2014-03-22 6:46 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 19, 2014 at 02:28:40PM +0100, Lothar Wa?mann wrote:
>
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> ---
> arch/arm/boot/dts/imx53-tx53-x13x.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> index 26b918e..86a964d 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> @@ -63,6 +63,18 @@
> default-brightness-level = <50>;
> };
>
> + panel0 {
> + compatible = "simple-panel";
>From what I can see, "simple-panel" is not a documented compatible.
Shawn
> + power-supply = <®_lcd_pwr0>;
> + backlight = <&backlight0>;
> + };
> +
> + panel1 {
> + compatible = "simple-panel";
> + power-supply = <®_lcd_pwr1>;
> + backlight = <&backlight1>;
> + };
> +
> regulators {
> reg_lcd_pwr0: regulator at 5 {
> compatible = "regulator-fixed";
> --
> 1.7.10.4
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 4/5] ARM: dts: tx53: add simple-panel support
2014-03-22 6:46 ` Shawn Guo
@ 2014-03-25 13:14 ` Lothar Waßmann
0 siblings, 0 replies; 11+ messages in thread
From: Lothar Waßmann @ 2014-03-25 13:14 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:28:40PM +0100, Lothar Wa?mann wrote:
> >
> > Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> > ---
> > arch/arm/boot/dts/imx53-tx53-x13x.dts | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > index 26b918e..86a964d 100644
> > --- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > +++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> > @@ -63,6 +63,18 @@
> > default-brightness-level = <50>;
> > };
> >
> > + panel0 {
> > + compatible = "simple-panel";
>
> From what I can see, "simple-panel" is not a documented compatible.
>
There is Documentation/devicetree/bindings/panel/simple-panel.txt
which describes the bindings for drivers/gpu/drm/panel/panel-simple.c.
"simple-panel" is the common compatible for all panels that the driver
supports. If no compatible for a specific panel is given, the
driver supports a generic panel with an ENABLE GPIO, an attached
backlight and a regulator. This is what's being used here.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints
2014-03-19 13:28 [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on Lothar Waßmann
` (2 preceding siblings ...)
2014-03-19 13:28 ` [PATCH 4/5] ARM: dts: tx53: add simple-panel support Lothar Waßmann
@ 2014-03-19 13:28 ` Lothar Waßmann
2014-03-22 6:50 ` Shawn Guo
2014-03-22 6:47 ` [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on Shawn Guo
4 siblings, 1 reply; 11+ messages in thread
From: Lothar Waßmann @ 2014-03-19 13:28 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
---
arch/arm/boot/dts/imx53-tx53-x03x.dts | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts
index 0217dde3..43b4b7b 100644
--- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
+++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
@@ -25,12 +25,17 @@
soc {
display: display at di0 {
compatible = "fsl,imx-parallel-display";
- crtcs = <&ipu 0>;
interface-pix-fmt = "rgb24";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_rgb24_vga1>;
status = "okay";
+ port {
+ display0_in: endpoint {
+ remote-endpoint = <&ipu_di0_disp0>;
+ };
+ };
+
display-timings {
VGA {
clock-frequency = <25200000>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints
2014-03-19 13:28 ` [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints Lothar Waßmann
@ 2014-03-22 6:50 ` Shawn Guo
2014-03-24 12:47 ` Lothar Waßmann
0 siblings, 1 reply; 11+ messages in thread
From: Shawn Guo @ 2014-03-22 6:50 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 19, 2014 at 02:28:41PM +0100, Lothar Wa?mann wrote:
>
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> ---
> arch/arm/boot/dts/imx53-tx53-x03x.dts | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> index 0217dde3..43b4b7b 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> @@ -25,12 +25,17 @@
> soc {
> display: display at di0 {
> compatible = "fsl,imx-parallel-display";
> - crtcs = <&ipu 0>;
> interface-pix-fmt = "rgb24";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rgb24_vga1>;
> status = "okay";
>
> + port {
> + display0_in: endpoint {
> + remote-endpoint = <&ipu_di0_disp0>;
> + };
> + };
> +
I shouldn't apply this until I rebase my branch on 3.15-rc1 where
Philipp's OF graph is to be seen, right?
Shawn
> display-timings {
> VGA {
> clock-frequency = <25200000>;
> --
> 1.7.10.4
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints
2014-03-22 6:50 ` Shawn Guo
@ 2014-03-24 12:47 ` Lothar Waßmann
0 siblings, 0 replies; 11+ messages in thread
From: Lothar Waßmann @ 2014-03-24 12:47 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:28:41PM +0100, Lothar Wa?mann wrote:
> >
> > Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> > ---
> > arch/arm/boot/dts/imx53-tx53-x03x.dts | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> > index 0217dde3..43b4b7b 100644
> > --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts
> > +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts
> > @@ -25,12 +25,17 @@
> > soc {
> > display: display at di0 {
> > compatible = "fsl,imx-parallel-display";
> > - crtcs = <&ipu 0>;
> > interface-pix-fmt = "rgb24";
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_rgb24_vga1>;
> > status = "okay";
> >
> > + port {
> > + display0_in: endpoint {
> > + remote-endpoint = <&ipu_di0_disp0>;
> > + };
> > + };
> > +
>
> I shouldn't apply this until I rebase my branch on 3.15-rc1 where
> Philipp's OF graph is to be seen, right?
>
That's ok with me.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on
2014-03-19 13:28 [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on Lothar Waßmann
` (3 preceding siblings ...)
2014-03-19 13:28 ` [PATCH 5/5] ARM: dts: tx53: Add IPU DI ports and endpoints Lothar Waßmann
@ 2014-03-22 6:47 ` Shawn Guo
2014-03-24 12:51 ` Lothar Waßmann
4 siblings, 1 reply; 11+ messages in thread
From: Shawn Guo @ 2014-03-22 6:47 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 19, 2014 at 02:28:37PM +0100, Lothar Wa?mann wrote:
>
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
Please add something in the commit log, e.g. why regulator-boot-on is
redundant in this case.
Shawn
> ---
> arch/arm/boot/dts/imx53-tx53-x13x.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx53-tx53-x13x.dts b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> index 6480471..c8a3473 100644
> --- a/arch/arm/boot/dts/imx53-tx53-x13x.dts
> +++ b/arch/arm/boot/dts/imx53-tx53-x13x.dts
> @@ -72,7 +72,6 @@
> regulator-max-microvolt = <3300000>;
> gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> - regulator-boot-on;
> };
>
> reg_lcd_pwr1: regulator at 6 {
> @@ -83,7 +82,6 @@
> regulator-max-microvolt = <3300000>;
> gpio = <&gpio2 31 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> - regulator-boot-on;
> };
> };
> };
> --
> 1.7.10.4
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on
2014-03-22 6:47 ` [PATCH 1/5] ARM: dts: tx53: remove redundant regulator-boot-on Shawn Guo
@ 2014-03-24 12:51 ` Lothar Waßmann
0 siblings, 0 replies; 11+ messages in thread
From: Lothar Waßmann @ 2014-03-24 12:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:28:37PM +0100, Lothar Wa?mann wrote:
> >
> > Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
>
> Please add something in the commit log, e.g. why regulator-boot-on is
> redundant in this case.
>
OK.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
^ permalink raw reply [flat|nested] 11+ messages in thread