From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Sat, 22 Mar 2014 11:42:01 -0700 Subject: [linux-sunxi] Re: [PATCH v2 1/8] mfd: AXP20x: Add mfd driver for AXP20x PMIC In-Reply-To: References: <1394898225-28452-1-git-send-email-carlo@caione.org> <1394898225-28452-2-git-send-email-carlo@caione.org> <20140318155919.GS25478@lee--X1> <20140322165132.GC20668@localhost.fastwebnet.it> <20140322173313.GU552@sirena.org.uk> Message-ID: <20140322184201.GA27611@core.coreip.homeip.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote: > On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown wrote: > > On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote: > >> On Tue, Mar 18, 2014 at 03:59:19PM +0000, Lee Jones wrote: > > > >> > > + of_id = of_match_device(axp20x_of_match, &i2c->dev); > >> > > + if (!of_id) { > >> > > + dev_err(&i2c->dev, "Unable to setup AXP20X data\n"); > >> > > + return -ENODEV; > >> > > + } > >> > > + axp20x->variant = (int) of_id->data; > > > >> > No need to cast from void *. > > > >> My compiler says otherwise :) > > > > Are you sure your compiler isn't correctly telling you not to cast away > > const? If the compiler is complaining about a cast on void then it's > > spotted a definite bug. > > [resend since gmail decided to not put broonie in CC] > > drivers/mfd/axp20x.c:172:18: warning: assignment makes integer > frompointer without a cast [enabled by default] You need to cast to long, otherwise you will get warnings when compiling on 64 bit arches. Thanks. -- Dmitry