From mboxrd@z Thu Jan 1 00:00:00 1970 From: wsa@the-dreams.de (Wolfram Sang) Date: Tue, 25 Mar 2014 13:00:59 +0100 Subject: [PATCH v3] i2c: new bus driver for efm32 In-Reply-To: References: <1395414236-22647-1-git-send-email-u.kleine-koenig@pengutronix.de> <20140324170131.GB7524@katana> <20140325090700.GL23076@pengutronix.de> <20140325091148.GA2570@katana> Message-ID: <20140325120059.GA2863@katana> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 25, 2014 at 11:17:49AM +0000, Andy Whitcroft wrote: > I would call it a false positive and ignore it.=A0 You need to justify any > reports from checkpatch that remain "this is more readable" seems a valid > justification. I agree in general. In this case, I think both options have their pros and cons in terms of readability, so I let the author decide. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: