From: s.trumtrar@pengutronix.de (Steffen Trumtrar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: socfpga: Remove hard coded clock-frequency property
Date: Thu, 3 Apr 2014 07:32:23 +0200 [thread overview]
Message-ID: <20140403053223.GC12170@pengutronix.de> (raw)
In-Reply-To: <1396492834-26035-2-git-send-email-dinguyen@altera.com>
Hi!
On Wed, Apr 02, 2014 at 09:40:34PM -0500, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> The timers and uart can get their clock frequencies using the common clock
> driver.
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> ---
> arch/arm/boot/dts/socfpga.dtsi | 10 ++++++++++
> arch/arm/boot/dts/socfpga_arria5.dtsi | 24 ------------------------
> arch/arm/boot/dts/socfpga_cyclone5.dtsi | 24 ------------------------
> 3 files changed, 10 insertions(+), 48 deletions(-)
>
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 039cebb..df43702 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -630,24 +630,32 @@
> compatible = "snps,dw-apb-timer";
> interrupts = <0 167 4>;
> reg = <0xffc08000 0x1000>;
> + clocks = <&l4_sp_clk>;
> + clock-names = "timer";
> };
>
> timer1: timer1 at ffc09000 {
> compatible = "snps,dw-apb-timer";
> interrupts = <0 168 4>;
> reg = <0xffc09000 0x1000>;
> + clocks = <&l4_sp_clk>;
> + clock-names = "timer";
> };
>
> timer2: timer2 at ffd00000 {
> compatible = "snps,dw-apb-timer";
> interrupts = <0 169 4>;
> reg = <0xffd00000 0x1000>;
> + clocks = <&osc1>;
> + clock-names = "timer";
> };
>
> timer3: timer3 at ffd01000 {
> compatible = "snps,dw-apb-timer";
> interrupts = <0 170 4>;
> reg = <0xffd01000 0x1000>;
> + clocks = <&osc1>;
> + clock-names = "timer";
> };
>
> uart0: serial0 at ffc02000 {
> @@ -656,6 +664,7 @@
> interrupts = <0 162 4>;
> reg-shift = <2>;
> reg-io-width = <4>;
> + clocks = <&l4_sp_clk>;
> };
>
> uart1: serial1 at ffc03000 {
> @@ -664,6 +673,7 @@
> interrupts = <0 163 4>;
> reg-shift = <2>;
> reg-io-width = <4>;
> + clocks = <&l4_sp_clk>;
> };
>
> rstmgr at ffd05000 {
> diff --git a/arch/arm/boot/dts/socfpga_arria5.dtsi b/arch/arm/boot/dts/socfpga_arria5.dtsi
> index 373b340..12d1c2c 100644
> --- a/arch/arm/boot/dts/socfpga_arria5.dtsi
> +++ b/arch/arm/boot/dts/socfpga_arria5.dtsi
> @@ -38,32 +38,8 @@
> };
> };
>
> - serial0 at ffc02000 {
> - clock-frequency = <100000000>;
> - };
> -
> - serial1 at ffc03000 {
> - clock-frequency = <100000000>;
> - };
> -
> sysmgr at ffd08000 {
> cpu1-start-addr = <0xffd080c4>;
> };
> -
> - timer0 at ffc08000 {
> - clock-frequency = <100000000>;
> - };
> -
> - timer1 at ffc09000 {
> - clock-frequency = <100000000>;
> - };
> -
> - timer2 at ffd00000 {
> - clock-frequency = <25000000>;
> - };
> -
> - timer3 at ffd01000 {
> - clock-frequency = <25000000>;
> - };
> };
> };
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5.dtsi b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
> index 63a9513..bf51182 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5.dtsi
> +++ b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
> @@ -45,30 +45,6 @@
> status = "okay";
> };
>
> - timer0 at ffc08000 {
> - clock-frequency = <100000000>;
> - };
> -
> - timer1 at ffc09000 {
> - clock-frequency = <100000000>;
> - };
> -
> - timer2 at ffd00000 {
> - clock-frequency = <25000000>;
> - };
> -
> - timer3 at ffd01000 {
> - clock-frequency = <25000000>;
> - };
> -
> - serial0 at ffc02000 {
> - clock-frequency = <100000000>;
> - };
> -
> - serial1 at ffc03000 {
> - clock-frequency = <100000000>;
> - };
> -
> sysmgr at ffd08000 {
> cpu1-start-addr = <0xffd080c4>;
> };
Ah, good. I like getting rid of stuff like this. Looks okay to me:
Reviewed-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Thanks,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-04-03 5:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 2:40 [PATCH 1/2] ARM: socfpga: dts: add eeprom, lcd, and rtc on i2c0 dinguyen at altera.com
2014-04-03 2:40 ` [PATCH 2/2] ARM: dts: socfpga: Remove hard coded clock-frequency property dinguyen at altera.com
2014-04-03 5:32 ` Steffen Trumtrar [this message]
2014-04-03 5:19 ` [PATCH 1/2] ARM: socfpga: dts: add eeprom, lcd, and rtc on i2c0 Steffen Trumtrar
2014-04-03 22:33 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403053223.GC12170@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).