* [PATCH] pinctrl: capri: make Kconfig dependency more strict
@ 2014-04-01 20:10 Uwe Kleine-König
2014-04-02 23:19 ` Sherman Yin
2014-04-10 16:55 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2014-04-01 20:10 UTC (permalink / raw)
To: linux-arm-kernel
This driver is only useful on BCM281xx, so let the driver depend on
ARCH_BCM_MOBILE but allow compile coverage testing.
The main benefit is that the driver isn't available to be selected for
machines that don't have the matching hardware.
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
drivers/pinctrl/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index e49324032611..072749816cb4 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -106,7 +106,7 @@ config PINCTRL_BCM2835
config PINCTRL_CAPRI
bool "Broadcom Capri pinctrl driver"
- depends on OF
+ depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
select PINMUX
select PINCONF
select GENERIC_PINCONF
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] pinctrl: capri: make Kconfig dependency more strict
2014-04-01 20:10 [PATCH] pinctrl: capri: make Kconfig dependency more strict Uwe Kleine-König
@ 2014-04-02 23:19 ` Sherman Yin
2014-04-03 8:01 ` Uwe Kleine-König
2014-04-10 16:55 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Sherman Yin @ 2014-04-02 23:19 UTC (permalink / raw)
To: linux-arm-kernel
On 14-04-01 01:10 PM, Uwe Kleine-K?nig wrote:
> This driver is only useful on BCM281xx, so let the driver depend on
> ARCH_BCM_MOBILE but allow compile coverage testing.
> The main benefit is that the driver isn't available to be selected for
> machines that don't have the matching hardware.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pinctrl/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index e49324032611..072749816cb4 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,7 +106,7 @@ config PINCTRL_BCM2835
>
> config PINCTRL_CAPRI
> bool "Broadcom Capri pinctrl driver"
> - depends on OF
> + depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
>
Looks good. Just wondering how you've come across this driver (and
PINCTRL_MSM8X74)?
Reviewed-by: Sherman Yin <syin@broadcom.com>
Thanks,
Sherman
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] pinctrl: capri: make Kconfig dependency more strict
2014-04-02 23:19 ` Sherman Yin
@ 2014-04-03 8:01 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2014-04-03 8:01 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Wed, Apr 02, 2014 at 04:19:58PM -0700, Sherman Yin wrote:
> On 14-04-01 01:10 PM, Uwe Kleine-K?nig wrote:
> >This driver is only useful on BCM281xx, so let the driver depend on
> >ARCH_BCM_MOBILE but allow compile coverage testing.
> >The main benefit is that the driver isn't available to be selected for
> >machines that don't have the matching hardware.
> >
> >Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> >---
> > drivers/pinctrl/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> >index e49324032611..072749816cb4 100644
> >--- a/drivers/pinctrl/Kconfig
> >+++ b/drivers/pinctrl/Kconfig
> >@@ -106,7 +106,7 @@ config PINCTRL_BCM2835
> >
> > config PINCTRL_CAPRI
> > bool "Broadcom Capri pinctrl driver"
> >- depends on OF
> >+ depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
> > select PINMUX
> > select PINCONF
> > select GENERIC_PINCONF
> >
>
> Looks good. Just wondering how you've come across this driver (and
> PINCTRL_MSM8X74)?
Well, I was annoyed by being asked if I want to enable them for my efm32
machine during make oldconfig after updating the kernel. :-)
> Reviewed-by: Sherman Yin <syin@broadcom.com>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] pinctrl: capri: make Kconfig dependency more strict
2014-04-01 20:10 [PATCH] pinctrl: capri: make Kconfig dependency more strict Uwe Kleine-König
2014-04-02 23:19 ` Sherman Yin
@ 2014-04-10 16:55 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2014-04-10 16:55 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 1, 2014 at 10:10 PM, Uwe Kleine-K?nig
<u.kleine-koenig@pengutronix.de> wrote:
> This driver is only useful on BCM281xx, so let the driver depend on
> ARCH_BCM_MOBILE but allow compile coverage testing.
> The main benefit is that the driver isn't available to be selected for
> machines that don't have the matching hardware.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Sherman is renaming this driver so this patch does not apply.
Please resubmit after the rename is upstream or something.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-10 16:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-01 20:10 [PATCH] pinctrl: capri: make Kconfig dependency more strict Uwe Kleine-König
2014-04-02 23:19 ` Sherman Yin
2014-04-03 8:01 ` Uwe Kleine-König
2014-04-10 16:55 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).