From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: i.MX6: update KSZ9031 phy fixup
Date: Sun, 6 Apr 2014 20:04:54 +0800 [thread overview]
Message-ID: <20140406120452.GD24260@dragon> (raw)
In-Reply-To: <20140406112655.GP7528@n2100.arm.linux.org.uk>
On Sun, Apr 06, 2014 at 12:26:55PM +0100, Russell King - ARM Linux wrote:
> Ergh. So much for "DT describes the hardware, not the software
> implementation."
>
> commit 954c396756e3d31985f7bc6a414a988a4736a7d0
> Author: Sean Cross <xobs@kosagi.com>
> Date: Wed Aug 21 01:46:12 2013 +0000
>
> net/phy: micrel: Add OF configuration support for ksz9021
>
> Some boards require custom PHY configuration, for example due to trace
> length differences. Add the ability to configure these registers in
> order to get the PHY to function on boards that need it.
>
> Because PHYs are auto-detected based on MDIO device IDs, allow PHY
> configuration to be specified in the parent Ethernet device node if no
> PHY device node is present.
>
> If we were describing the hardware, we'd create a node for the phy and put
> the phy specific properties in there, and reference it from the ethernet
> driver, and have some way to look up the phy node when we automatically
> discover the phy.
This is exactly how new style devices work, like allwinner case below.
arch/arm/boot/dts/sun4i-a10-a1000.dts
drivers/net/ethernet/allwinner/sun4i-emac.c
>
> Well, it's too late to do anything else now, we're stuck with this, and
> I guess everyone's going to be stuffing the phy chip's configuration into
> the ethernet device's node from now on. :(
Let's take a look at ksz9021_config_init().
if (!of_node && dev->parent->of_node)
of_node = dev->parent->of_node;
It's a stepping back in case that the phy device has no of_node
attached. So for phy devices that are initiated from device tree like
allwinner case above, they will just work in the sane way.
Shawn
prev parent reply other threads:[~2014-04-06 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 17:08 [PATCH] ARM: i.MX6: update KSZ9031 phy fixup Hubert Chaumette
2014-03-21 21:23 ` Eric Bénard
2014-03-24 15:30 ` CHAUMETTE Hubert
2014-03-24 15:41 ` Eric Bénard
2014-04-02 13:14 ` Shawn Guo
2014-04-02 13:38 ` Eric Bénard
2014-04-02 14:14 ` Ben Dooks
2014-04-02 20:01 ` Anatolij Gustschin
2014-04-03 14:05 ` Hubert Chaumette
2014-04-03 14:56 ` Anatolij Gustschin
2014-04-06 11:06 ` Shawn Guo
2014-04-06 11:26 ` Russell King - ARM Linux
2014-04-06 12:04 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140406120452.GD24260@dragon \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox