From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: cadence: fix Kconfig dependency
Date: Mon, 7 Apr 2014 08:31:00 +0200 [thread overview]
Message-ID: <20140407063100.GN29751@pengutronix.de> (raw)
In-Reply-To: <1396811227-8851-1-git-send-email-wsa@the-dreams.de>
Hello,
On Sun, Apr 06, 2014 at 09:07:07PM +0200, Wolfram Sang wrote:
> During development, the driver first really needed to depend on
> COMMON_CLK only. Later, it was switched to writel_relaxed, but it was
> forgotten to update the dependencies, so build errors occured:
>
> config: make ARCH=i386 allyesconfig
>
> All error/warnings:
>
> drivers/i2c/busses/i2c-cadence.c: In function 'cdns_i2c_clear_bus_hold':
> >> drivers/i2c/busses/i2c-cadence.c:168:3: error: implicit declaration
> >> of function 'writel_relaxed' [-Werror=implicit-function-declaration]
>
> Use a very safe dependency for now.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 93165ff453ab..3d3b9b3577c5 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -378,7 +378,7 @@ config I2C_BLACKFIN_TWI_CLK_KHZ
>
> config I2C_CADENCE
> tristate "Cadence I2C Controller"
> - depends on COMMON_CLK
> + depends on ARCH_ZYNQ
I'd suggest:
depends on ARM && (ARCH_ZYNC || COMPILE_TEST)
This way it's available for compile testing but still it doesn't appear
when configuring a kernel for a real machine.
Best regards
Uwe
> help
> Say yes here to select Cadence I2C Host Controller. This controller is
> e.g. used by Xilinx Zynq.
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-04-07 6:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 19:07 [PATCH] i2c: cadence: fix Kconfig dependency Wolfram Sang
2014-04-06 22:13 ` Sören Brinkmann
2014-04-07 6:31 ` Uwe Kleine-König [this message]
2014-04-07 6:37 ` Alexander Shiyan
2014-04-07 6:56 ` Uwe Kleine-König
2014-04-07 7:02 ` Alexander Shiyan
2014-04-07 16:18 ` Sören Brinkmann
2014-05-21 8:29 ` Wolfram Sang
2014-05-21 16:00 ` Sören Brinkmann
2014-05-22 4:58 ` Michal Simek
2014-04-07 15:36 ` Sören Brinkmann
2014-04-07 17:50 ` Uwe Kleine-König
2014-04-07 6:39 ` Michal Simek
2014-04-07 6:56 ` Wolfram Sang
2014-04-07 7:00 ` Michal Simek
2014-04-08 8:33 ` Michal Simek
2014-04-07 15:37 ` Sören Brinkmann
2014-04-07 16:14 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407063100.GN29751@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).