linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: cadence: fix Kconfig dependency
Date: Mon, 7 Apr 2014 19:50:38 +0200	[thread overview]
Message-ID: <20140407175038.GS29751@pengutronix.de> (raw)
In-Reply-To: <dfab53fa-8b3c-4eb0-90b8-7df779ce68da@TX2EHSMHS036.ehs.local>

Hello S?ren,

On Mon, Apr 07, 2014 at 08:36:29AM -0700, S?ren Brinkmann wrote:
> On Mon, 2014-04-07 at 10:37AM +0400, Alexander Shiyan wrote:
> > ARCH_ZYNC || (ARM && COMPILE_TEST)
> 
> Why would you add Zynq to the dependencies? This driver should work on
> all ARM platforms (more or less, given that the IP is implemented
> similarly). I think ARM, if it selects COMMON_CLK, is enough. Otherwise
> ARM && COMMON_CLK. I don't see a good reason to restrict the driver to
> Zynq only.
The idea is that if COMPILE_TEST is off you can only enable the driver
for machines where the device in question really exists to simplify
kernel configuration. Sometimes this isn't really possible, e.g. for i2c
devices that can be put on more or less every machine. I had the
impression that the cadence i2c bus device only exists on Zync? Ok, you
could implement this device on every SoC that has some programmable
hardware, but that is not the point.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2014-04-07 17:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-06 19:07 [PATCH] i2c: cadence: fix Kconfig dependency Wolfram Sang
2014-04-06 22:13 ` Sören Brinkmann
2014-04-07  6:31 ` Uwe Kleine-König
2014-04-07  6:37   ` Alexander Shiyan
2014-04-07  6:56     ` Uwe Kleine-König
2014-04-07  7:02       ` Alexander Shiyan
2014-04-07 16:18         ` Sören Brinkmann
2014-05-21  8:29           ` Wolfram Sang
2014-05-21 16:00             ` Sören Brinkmann
2014-05-22  4:58               ` Michal Simek
2014-04-07 15:36     ` Sören Brinkmann
2014-04-07 17:50       ` Uwe Kleine-König [this message]
2014-04-07  6:39   ` Michal Simek
2014-04-07  6:56     ` Wolfram Sang
2014-04-07  7:00       ` Michal Simek
2014-04-08  8:33       ` Michal Simek
2014-04-07 15:37     ` Sören Brinkmann
2014-04-07 16:14   ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140407175038.GS29751@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).