* [PATCH] ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
@ 2014-04-11 12:09 Fabio Estevam
2014-04-11 12:15 ` Marek Vasut
2014-04-13 8:05 ` Shawn Guo
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2014-04-11 12:09 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
In case the bootloader has incorrectly configured the ALT mode of
MX6SL_PAD_ECSPI1_SS0 pad, we end up with the following probe error:
m25p80 spi0.0: found mr25h256, expected m25p32
m25p80 spi0.0: mr25h256 (32 Kbytes)
In order to avoid this issue, add an entry for MX6SL_PAD_ECSPI1_SS0 pad, so
that kernel configures the ECSPI chip select as GPIO functionality, which
results in correct SPI NOR probe.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/boot/dts/imx6sl-evk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts
index 864d8df..a8d9a93 100644
--- a/arch/arm/boot/dts/imx6sl-evk.dts
+++ b/arch/arm/boot/dts/imx6sl-evk.dts
@@ -282,6 +282,7 @@
MX6SL_PAD_ECSPI1_MISO__ECSPI1_MISO 0x100b1
MX6SL_PAD_ECSPI1_MOSI__ECSPI1_MOSI 0x100b1
MX6SL_PAD_ECSPI1_SCLK__ECSPI1_SCLK 0x100b1
+ MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11 0x80000000
>;
};
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
2014-04-11 12:09 [PATCH] ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11 Fabio Estevam
@ 2014-04-11 12:15 ` Marek Vasut
2014-04-11 12:18 ` Fabio Estevam
2014-04-13 8:05 ` Shawn Guo
1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2014-04-11 12:15 UTC (permalink / raw)
To: linux-arm-kernel
On Friday, April 11, 2014 at 02:09:39 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> In case the bootloader has incorrectly configured the ALT mode of
> MX6SL_PAD_ECSPI1_SS0 pad, we end up with the following probe error:
>
> m25p80 spi0.0: found mr25h256, expected m25p32
> m25p80 spi0.0: mr25h256 (32 Kbytes)
>
> In order to avoid this issue, add an entry for MX6SL_PAD_ECSPI1_SS0 pad, so
> that kernel configures the ECSPI chip select as GPIO functionality, which
> results in correct SPI NOR probe.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/boot/dts/imx6sl-evk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx6sl-evk.dts
> b/arch/arm/boot/dts/imx6sl-evk.dts index 864d8df..a8d9a93 100644
> --- a/arch/arm/boot/dts/imx6sl-evk.dts
> +++ b/arch/arm/boot/dts/imx6sl-evk.dts
> @@ -282,6 +282,7 @@
> MX6SL_PAD_ECSPI1_MISO__ECSPI1_MISO 0x100b1
> MX6SL_PAD_ECSPI1_MOSI__ECSPI1_MOSI 0x100b1
> MX6SL_PAD_ECSPI1_SCLK__ECSPI1_SCLK 0x100b1
> + MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
0x80000000
Doesn't 0x80000000 mean "do not configure this pin, leave it as it was
configured before" ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
2014-04-11 12:15 ` Marek Vasut
@ 2014-04-11 12:18 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2014-04-11 12:18 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 11, 2014 at 9:15 AM, Marek Vasut <marex@denx.de> wrote:
>> diff --git a/arch/arm/boot/dts/imx6sl-evk.dts
>> b/arch/arm/boot/dts/imx6sl-evk.dts index 864d8df..a8d9a93 100644
>> --- a/arch/arm/boot/dts/imx6sl-evk.dts
>> +++ b/arch/arm/boot/dts/imx6sl-evk.dts
>> @@ -282,6 +282,7 @@
>> MX6SL_PAD_ECSPI1_MISO__ECSPI1_MISO 0x100b1
>> MX6SL_PAD_ECSPI1_MOSI__ECSPI1_MOSI 0x100b1
>> MX6SL_PAD_ECSPI1_SCLK__ECSPI1_SCLK 0x100b1
>> + MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
> 0x80000000
>
> Doesn't 0x80000000 mean "do not configure this pin, leave it as it was
> configured before" ?
For the PAD settings, yes, but here I am interested in setting the ALT
mode to GPIO.
It is OK to leave the PAD settings as is for the GPIO.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11
2014-04-11 12:09 [PATCH] ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11 Fabio Estevam
2014-04-11 12:15 ` Marek Vasut
@ 2014-04-13 8:05 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2014-04-13 8:05 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 11, 2014 at 09:09:39AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> In case the bootloader has incorrectly configured the ALT mode of
> MX6SL_PAD_ECSPI1_SS0 pad, we end up with the following probe error:
>
> m25p80 spi0.0: found mr25h256, expected m25p32
> m25p80 spi0.0: mr25h256 (32 Kbytes)
>
> In order to avoid this issue, add an entry for MX6SL_PAD_ECSPI1_SS0 pad, so
> that kernel configures the ECSPI chip select as GPIO functionality, which
> results in correct SPI NOR probe.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-13 8:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-11 12:09 [PATCH] ARM: dts: imx6sl-evk: Add an entry for MX6SL_PAD_ECSPI1_SS0__GPIO4_IO11 Fabio Estevam
2014-04-11 12:15 ` Marek Vasut
2014-04-11 12:18 ` Fabio Estevam
2014-04-13 8:05 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).