From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] ARM: dts: imx51-babbage: Use separate pingroup for fixed-clock
Date: Sun, 13 Apr 2014 16:18:07 +0800 [thread overview]
Message-ID: <20140413081806.GH24180@dragon> (raw)
In-Reply-To: <1397366353-29395-2-git-send-email-shc_work@mail.ru>
On Sun, Apr 13, 2014 at 09:19:05AM +0400, Alexander Shiyan wrote:
> This patch moves GPIOs definitions for "fixed-clock" into a separate
> pingroup.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boot/dts/imx51-babbage.dts | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
> index eddb62d..651a8c8 100644
> --- a/arch/arm/boot/dts/imx51-babbage.dts
> +++ b/arch/arm/boot/dts/imx51-babbage.dts
> @@ -125,6 +125,8 @@
>
> clk_26M: codec_clock {
> compatible = "fixed-clock";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_clkcodec>;
Are you sure that pinctrl-* settings work for a fixed-clock? My
impression is that it only works for the device that Linux creates
struct device and probes for.
Shawn
> reg=<0>;
> #clock-cells = <0>;
> clock-frequency = <26000000>;
> @@ -337,7 +339,6 @@
> MX51_PAD_GPIO1_6__GPIO1_6 0x100
> MX51_PAD_CSPI1_SS0__GPIO4_24 0x85
> MX51_PAD_CSPI1_SS1__GPIO4_25 0x85
> - MX51_PAD_CSPI1_RDY__GPIO4_26 0x80000000
> >;
> };
>
> @@ -350,6 +351,12 @@
> >;
> };
>
> + pinctrl_clkcodec: clkcodecgrp {
> + fsl,pins = <
> + MX51_PAD_CSPI1_RDY__GPIO4_26 0x80000000
> + >;
> + };
> +
> pinctrl_ecspi1: ecspi1grp {
> fsl,pins = <
> MX51_PAD_CSPI1_MISO__ECSPI1_MISO 0x185
> --
> 1.8.3.2
>
>
>
next prev parent reply other threads:[~2014-04-13 8:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 5:19 [PATCH 01/10] ARM: dts: imx51-babbage: Use separate pingroup for gpio-keys Alexander Shiyan
2014-04-13 5:19 ` [PATCH 02/10] ARM: dts: imx51-babbage: Use separate pingroup for fixed-clock Alexander Shiyan
2014-04-13 8:18 ` Shawn Guo [this message]
2014-04-13 8:33 ` Alexander Shiyan
2014-04-13 5:19 ` [PATCH 03/10] ARM: dts: imx51-babbage: Use separate pingroup for regulator-fixed Alexander Shiyan
2014-04-13 5:19 ` [PATCH 04/10] ARM: dts: imx51-babbage: Move "hog" pins into corresponded pin groups Alexander Shiyan
2014-04-13 5:19 ` [PATCH 05/10] ARM: dts: imx51-babbage: Add missing pingroup for PMIC Alexander Shiyan
2014-04-13 5:19 ` [PATCH 06/10] ARM: dts: imx51-babbage: Use predefined constants for keys definition Alexander Shiyan
2014-04-13 5:19 ` [PATCH 07/10] ARM: dts: imx51-babbage: Add USB OTG regulator node Alexander Shiyan
2014-04-13 5:19 ` [PATCH 08/10] ARM: dts: imx51-babbage: Sort nodes by name Alexander Shiyan
2014-04-13 5:19 ` [PATCH 09/10] ARM: dts: imx51-babbage: Add "clock-frequency" property for I2C2 Alexander Shiyan
2014-04-13 8:22 ` Shawn Guo
2014-04-13 5:19 ` [PATCH 10/10] ARM: dts: imx51-babbage: Add devicetree node for I2C1 Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140413081806.GH24180@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).