[PATCH 0/4] sunxi clock fixes

[PATCH 0/4] sunxi clock fixes

[Emilio López]

Hi everyone,

This is a small series of patches fixing a couple of bugs that are 
present on the sunxi clock driver. Mike, are there any chances we can
take these during the 3.15 merge window or -rc period?

Cheers,

Emilio

Emilio L?pez (4):
  clk: sunxi: fix A20 PLL4 calculation
  ARM: sun7i: fix PLL4 clock and add PLL8
  clk: sunxi: fix some calculations
  clk: sunxi: fix thinko in comment

 arch/arm/boot/dts/sun7i-a20.dtsi | 10 +++++++++-
 drivers/clk/sunxi/clk-sunxi.c    | 15 +++++++++++----
 2 files changed, 20 insertions(+), 5 deletions(-)

-- 
1.9.0

[PATCH 1/4] clk: sunxi: fix A20 PLL4 calculation

[Emilio López]

Allwinner actually reworked the PLL4 on A20; now it's compatible with
the sun4i PLL5/6 design previous to any divisions, as well as to the new
PLL8 in sun7i.

Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
---
 drivers/clk/sunxi/clk-sunxi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index 7ca9ed9..a393df1 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -621,6 +621,12 @@ static const struct factors_data sun6i_a31_pll1_data __initconst = {
 	.getter = sun6i_a31_get_pll1_factors,
 };
 
+static const struct factors_data sun7i_a20_pll4_data __initconst = {
+	.enable = 31,
+	.table = &sun4i_pll5_config,
+	.getter = sun4i_get_pll5_factors,
+};
+
 static const struct factors_data sun4i_pll5_data __initconst = {
 	.enable = 31,
 	.table = &sun4i_pll5_config,
@@ -1244,6 +1250,7 @@ free_clkdata:
 static const struct of_device_id clk_factors_match[] __initconst = {
 	{.compatible = "allwinner,sun4i-a10-pll1-clk", .data = &sun4i_pll1_data,},
 	{.compatible = "allwinner,sun6i-a31-pll1-clk", .data = &sun6i_a31_pll1_data,},
+	{.compatible = "allwinner,sun7i-a20-pll4-clk", .data = &sun7i_a20_pll4_data,},
 	{.compatible = "allwinner,sun6i-a31-pll6-clk", .data = &sun6i_a31_pll6_data,},
 	{.compatible = "allwinner,sun5i-a13-ahb-clk", .data = &sun5i_a13_ahb_data,},
 	{.compatible = "allwinner,sun4i-a10-apb1-clk", .data = &sun4i_apb1_data,},
-- 
1.9.0

[PATCH 2/4] ARM: sun7i: fix PLL4 clock and add PLL8

[Emilio López]

Allwinner reworked the PLL4 clock in sun7i; so we need to change the
compatible. Additionally, PLL8 is compatible with this new PLL4
implementation, so let's add a node for it as well.

Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index e766c6a..4e58ee5 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -71,7 +71,7 @@
 
 		pll4: clk at 01c20018 {
 			#clock-cells = <0>;
-			compatible = "allwinner,sun4i-a10-pll1-clk";
+			compatible = "allwinner,sun7i-a20-pll4-clk";
 			reg = <0x01c20018 0x4>;
 			clocks = <&osc24M>;
 			clock-output-names = "pll4";
@@ -93,6 +93,14 @@
 			clock-output-names = "pll6_sata", "pll6_other", "pll6";
 		};
 
+		pll8: clk at 01c20040 {
+			#clock-cells = <0>;
+			compatible = "allwinner,sun7i-a20-pll4-clk";
+			reg = <0x01c20040 0x4>;
+			clocks = <&osc24M>;
+			clock-output-names = "pll8";
+		};
+
 		cpu: cpu at 01c20054 {
 			#clock-cells = <0>;
 			compatible = "allwinner,sun4i-a10-cpu-clk";
-- 
1.9.0

[PATCH 3/4] clk: sunxi: fix some calculations

[Emilio López]

Some divisor calculations were misrounded, causing higher than requested
rates on some clocks. Fix them up using DIV_ROUND_UP, and replace one
homebrew instance of it as well with the right macro.

Reported-by: Boris BREZILLON <b.brezillon.dev@gmail.com>
Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
---
 drivers/clk/sunxi/clk-sunxi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index a393df1..0393f85 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -326,7 +326,7 @@ static void sun4i_get_apb1_factors(u32 *freq, u32 parent_rate,
 	if (parent_rate < *freq)
 		*freq = parent_rate;
 
-	parent_rate = (parent_rate + (*freq - 1)) / *freq;
+	parent_rate = DIV_ROUND_UP(parent_rate, *freq);
 
 	/* Invalid rate! */
 	if (parent_rate > 32)
@@ -371,7 +371,7 @@ static void sun4i_get_mod0_factors(u32 *freq, u32 parent_rate,
 	if (*freq > parent_rate)
 		*freq = parent_rate;
 
-	div = parent_rate / *freq;
+	div = DIV_ROUND_UP(parent_rate, *freq);
 
 	if (div < 16)
 		calcp = 0;
@@ -412,7 +412,7 @@ static void sun7i_a20_get_out_factors(u32 *freq, u32 parent_rate,
 	if (*freq > parent_rate)
 		*freq = parent_rate;
 
-	div = parent_rate / *freq;
+	div = DIV_ROUND_UP(parent_rate, *freq);
 
 	if (div < 32)
 		calcp = 0;
-- 
1.9.0

[PATCH 4/4] clk: sunxi: fix thinko in comment

[Emilio López]

This should read MOD0 and not MMC; MMC is just one example of a MOD0
clock.

Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
---
 drivers/clk/sunxi/clk-sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index 0393f85..4369c1f 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -357,7 +357,7 @@ static void sun4i_get_apb1_factors(u32 *freq, u32 parent_rate,
 
 /**
  * sun4i_get_mod0_factors() - calculates m, n factors for MOD0-style clocks
- * MMC rate is calculated as follows
+ * MOD0 rate is calculated as follows
  * rate = (parent_rate >> p) / (m + 1);
  */
 
-- 
1.9.0

[PATCH 0/4] sunxi clock fixes

[Mike Turquette]

Quoting Emilio L?pez (2014-03-19 11:19:29)
> Hi everyone,
> 
> This is a small series of patches fixing a couple of bugs that are 
> present on the sunxi clock driver. Mike, are there any chances we can
> take these during the 3.15 merge window or -rc period?

I can take these towards 3.15. Do you want me to take the dts patch too?

Regards,
Mike

> 
> Cheers,
> 
> Emilio
> 
> Emilio L?pez (4):
>   clk: sunxi: fix A20 PLL4 calculation
>   ARM: sun7i: fix PLL4 clock and add PLL8
>   clk: sunxi: fix some calculations
>   clk: sunxi: fix thinko in comment
> 
>  arch/arm/boot/dts/sun7i-a20.dtsi | 10 +++++++++-
>  drivers/clk/sunxi/clk-sunxi.c    | 15 +++++++++++----
>  2 files changed, 20 insertions(+), 5 deletions(-)
> 
> -- 
> 1.9.0
> 

[PATCH 0/4] sunxi clock fixes

[Emilio López]

Hi Mike,

El 19/03/14 16:04, Mike Turquette escribi?:
> Quoting Emilio L?pez (2014-03-19 11:19:29)
>> Hi everyone,
>>
>> This is a small series of patches fixing a couple of bugs that are
>> present on the sunxi clock driver. Mike, are there any chances we can
>> take these during the 3.15 merge window or -rc period?
>
> I can take these towards 3.15. Do you want me to take the dts patch too?

I'd rather have Maxime take it to avoid potential conflicts. That patch 
can wait in any case; there's no actual pll4 consumer in tree just yet.

Cheers,

Emilio

[PATCH 1/4] clk: sunxi: fix A20 PLL4 calculation

[Mike Turquette]

Quoting Emilio L?pez (2014-03-19 11:19:30)
> Allwinner actually reworked the PLL4 on A20; now it's compatible with
> the sun4i PLL5/6 design previous to any divisions, as well as to the new
> PLL8 in sun7i.
> 
> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>

Trivial merge conflict after applying this patch on top of your 3.15
pull request. My resolution is below. Let me know if I've made a
mistake.

Regards,
Mike



>From 5a8ddf26822dcf601a44d35efa8fe162cbc84e62 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Emilio=20L=C3=B3pez?= <emilio@elopez.com.ar>
Date: Wed, 19 Mar 2014 15:19:30 -0300
Subject: [PATCH] clk: sunxi: fix A20 PLL4 calculation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Allwinner actually reworked the PLL4 on A20; now it's compatible with
the sun4i PLL5/6 design previous to any divisions, as well as to the new
PLL8 in sun7i.

Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
---
 drivers/clk/sunxi/clk-sunxi.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
index 23baad9..ef6ad52b 100644
--- a/drivers/clk/sunxi/clk-sunxi.c
+++ b/drivers/clk/sunxi/clk-sunxi.c
@@ -589,6 +589,12 @@ static const struct factors_data sun6i_a31_pll1_data __initconst = {
 	.getter = sun6i_a31_get_pll1_factors,
 };
 
+static const struct factors_data sun7i_a20_pll4_data __initconst = {
+	.enable = 31,
+	.table = &sun4i_pll5_config,
+	.getter = sun4i_get_pll5_factors,
+};
+
 static const struct factors_data sun4i_pll5_data __initconst = {
 	.enable = 31,
 	.table = &sun4i_pll5_config,
@@ -1209,6 +1215,7 @@ free_clkdata:
 static const struct of_device_id clk_factors_match[] __initconst = {
 	{.compatible = "allwinner,sun4i-a10-pll1-clk", .data = &sun4i_pll1_data,},
 	{.compatible = "allwinner,sun6i-a31-pll1-clk", .data = &sun6i_a31_pll1_data,},
+	{.compatible = "allwinner,sun7i-a20-pll4-clk", .data = &sun7i_a20_pll4_data,},
 	{.compatible = "allwinner,sun6i-a31-pll6-clk", .data = &sun6i_a31_pll6_data,},
 	{.compatible = "allwinner,sun4i-a10-apb1-clk", .data = &sun4i_apb1_data,},
 	{.compatible = "allwinner,sun4i-a10-mod0-clk", .data = &sun4i_mod0_data,},
-- 
1.8.3.2

[PATCH 1/4] clk: sunxi: fix A20 PLL4 calculation

[Emilio López]

Hi Mike,

El 19/03/14 16:42, Mike Turquette escribi?:
> Quoting Emilio L?pez (2014-03-19 11:19:30)
>> Allwinner actually reworked the PLL4 on A20; now it's compatible with
>> the sun4i PLL5/6 design previous to any divisions, as well as to the new
>> PLL8 in sun7i.
>>
>> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
>
> Trivial merge conflict after applying this patch on top of your 3.15
> pull request. My resolution is below. Let me know if I've made a
> mistake.

Looks good to me.

Thanks!

Emilio

[PATCH 0/4] sunxi clock fixes

[Maxime Ripard]

Hi,

On Wed, Mar 19, 2014 at 04:15:26PM -0300, Emilio L?pez wrote:
> Hi Mike,
> 
> El 19/03/14 16:04, Mike Turquette escribi?:
> >Quoting Emilio L?pez (2014-03-19 11:19:29)
> >>Hi everyone,
> >>
> >>This is a small series of patches fixing a couple of bugs that are
> >>present on the sunxi clock driver. Mike, are there any chances we can
> >>take these during the 3.15 merge window or -rc period?
> >
> >I can take these towards 3.15. Do you want me to take the dts patch too?
> 
> I'd rather have Maxime take it to avoid potential conflicts. That
> patch can wait in any case; there's no actual pll4 consumer in tree
> just yet.

I sent my last pull request for the merge window, but I can queue it
up as a fix for a later 3.15-rc*

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140320/78607325/attachment-0001.sig>

[PATCH 0/4] sunxi clock fixes

[Mike Turquette]

Quoting Maxime Ripard (2014-03-20 08:15:51)
> Hi,
> 
> On Wed, Mar 19, 2014 at 04:15:26PM -0300, Emilio L?pez wrote:
> > Hi Mike,
> > 
> > El 19/03/14 16:04, Mike Turquette escribi?:
> > >Quoting Emilio L?pez (2014-03-19 11:19:29)
> > >>Hi everyone,
> > >>
> > >>This is a small series of patches fixing a couple of bugs that are
> > >>present on the sunxi clock driver. Mike, are there any chances we can
> > >>take these during the 3.15 merge window or -rc period?
> > >
> > >I can take these towards 3.15. Do you want me to take the dts patch too?
> > 
> > I'd rather have Maxime take it to avoid potential conflicts. That
> > patch can wait in any case; there's no actual pll4 consumer in tree
> > just yet.
> 
> I sent my last pull request for the merge window, but I can queue it
> up as a fix for a later 3.15-rc*

Just FYI, I took the three clock patches into clk-next yesterday so they
should land in linux-next soon.

Regards,
Mike

> 
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

[PATCH 2/4] ARM: sun7i: fix PLL4 clock and add PLL8

[Maxime Ripard]

On Wed, Mar 19, 2014 at 03:19:31PM -0300, Emilio L?pez wrote:
> Allwinner reworked the PLL4 clock in sun7i; so we need to change the
> compatible. Additionally, PLL8 is compatible with this new PLL4
> implementation, so let's add a node for it as well.
> 
> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>

Applied to sunxi/fixes-for-3.15.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140414/ab8d5ed0/attachment.sig>