From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Mon, 14 Apr 2014 11:53:14 +0100 Subject: [PATCH v9 1/2] ARM: avoid tracers in soft_restart In-Reply-To: <1395178858-27343-2-git-send-email-sebastian.capella@linaro.org> References: <1395178858-27343-1-git-send-email-sebastian.capella@linaro.org> <1395178858-27343-2-git-send-email-sebastian.capella@linaro.org> Message-ID: <20140414105314.GB3530@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sebastian, On Tue, Mar 18, 2014 at 09:40:57PM +0000, Sebastian Capella wrote: > Use of tracers in local_irq_disable is causes abort loops when called > with irqs disabled using a temporary stack. Replace local_irq_disable > with raw_local_irq_disable instead to avoid tracers. Do you have any more information about these aborts? At the time we call local_irq_disable, the stack is still intact, so if the issue is simply related to having any tracers active at the call_with_stack invocation, we'd be better off disabling tracing here altogether. Will > Signed-off-by: Sebastian Capella > Cc: Russell King > Cc: Andrew Morton > Cc: Will Deacon > Cc: Robin Holt > Cc: Thomas Gleixner > Cc: Konstantin Khlebnikov > Cc: Steven Capper > Cc: Stephen Warren > Cc: Tejun Heo > --- > arch/arm/kernel/process.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c > index 92f7b15..f58b723 100644 > --- a/arch/arm/kernel/process.c > +++ b/arch/arm/kernel/process.c > @@ -100,7 +100,7 @@ void soft_restart(unsigned long addr) > u64 *stack = soft_restart_stack + ARRAY_SIZE(soft_restart_stack); > > /* Disable interrupts first */ > - local_irq_disable(); > + raw_local_irq_disable(); > local_fiq_disable(); > > /* Disable the L2 if we're the last man standing. */ > -- > 1.7.9.5 > >