From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM : kdump : add arch_crash_save_vmcoreinfo
Date: Mon, 14 Apr 2014 12:37:18 +0100 [thread overview]
Message-ID: <20140414113718.GD3530@arm.com> (raw)
In-Reply-To: <1395907240-13308-3-git-send-email-sdu.liu@huawei.com>
On Thu, Mar 27, 2014 at 08:00:39AM +0000, Liu Hua wrote:
> For vmcore generated by LPAE enabled kernel, user space
> utility such as crash needs additional infomation to
> parse.
>
> So this patch add arch_crash_save_vmcoreinfo as what PAE enabled
> i386 linux does.
Looks sensible to me:
Reviewed-by: Will Deacon <will.deacon@arm.com>
Will
> Signed-off-by: Liu Hua <sdu.liu@huawei.com>
> To: Russell King <linux@arm.linux.org.uk>
> Cc: Stephen Warren <swarren@nvidia.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Vijaya Kumar K <vijay.kilari@gmail.com>
> Cc: <linux-arm-kernel@lists.infradead.org>
> Cc: <linux-kernel@vger.kernel.org>
> Cc: <kexec@lists.infradead.org>
> ---
> arch/arm/kernel/machine_kexec.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
> index f0d180d..8cf0996 100644
> --- a/arch/arm/kernel/machine_kexec.c
> +++ b/arch/arm/kernel/machine_kexec.c
> @@ -184,3 +184,10 @@ void machine_kexec(struct kimage *image)
>
> soft_restart(reboot_entry_phys);
> }
> +
> +void arch_crash_save_vmcoreinfo(void)
> +{
> +#ifdef CONFIG_ARM_LPAE
> + VMCOREINFO_CONFIG(ARM_LPAE);
> +#endif
> +}
> --
> 1.9.0
>
>
next prev parent reply other threads:[~2014-04-14 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 8:00 [PATCH 0/3] add LPAE support for kexec and kernel Liu Hua
2014-03-27 8:00 ` [PATCH 1/3] ARM : kdump : Add LPAE support Liu Hua
2014-03-27 8:00 ` [PATCH 2/3] ARM : kdump : add arch_crash_save_vmcoreinfo Liu Hua
2014-04-14 11:37 ` Will Deacon [this message]
2014-04-14 12:41 ` Liu hua
2014-04-14 17:31 ` Will Deacon
2014-03-27 8:00 ` [PATCH 3/3] kexec : ARM : add LPAE support Liu Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414113718.GD3530@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).