public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] ARM: mvebu: fix bus width handling in mvebu-devbus
Date: Mon, 14 Apr 2014 14:00:31 -0300	[thread overview]
Message-ID: <20140414170031.GB527@arch.cereza> (raw)
In-Reply-To: <1397489361-5833-1-git-send-email-thomas.petazzoni@free-electrons.com>

On Apr 14, Thomas Petazzoni wrote:
> Jason, Greg, Andrew, Sebastian,
> 
> This set of patches fix a bug in the mvebu-devbus driver, which was
> leading to a misinterpretation of Device Tree provided value: a NOR
> bus width declared as 8 bits in the Device Tree was in fact configured
> as 16 bits at the hardware level.
> 
> This bug was not noticed until now, because it was compensated by a
> symetric mistake in the Device Tree files.
> 
> This set of commits therefore fix both the driver itself, and the
> incorrect Device Tree files. The patches for the Device Tree files
> have been separated, because some of them should apply all the way to
> v3.10, while some of them apply only up to v3.11.
> 
> Changes since v1:
> 
>  * Added patches to fix the Device Tree files to indicate the correct
>    bus width, as documented in the board schematics. Noticed by
>    Ezequiel Garcia.
> 
>  * Changed the bus_width conversion logic in the driver to only accept
>    valid values: 8 bits and 16 bits. All other values lead to an error
>    being returned. Suggested by Sebastian Hesselbarth.
> 
>  * Rebased on top of v3.15-rc1.
> 

Thanks a lot for taking care of this!

Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

  parent reply	other threads:[~2014-04-14 17:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14 15:29 [PATCH v2 0/4] ARM: mvebu: fix bus width handling in mvebu-devbus Thomas Petazzoni
2014-04-14 15:29 ` [PATCH v2 1/4] memory: mvebu-devbus: fix the conversion of the bus width Thomas Petazzoni
2014-04-16 21:09   ` Jason Cooper
2014-04-16 21:28     ` Thomas Petazzoni
2014-04-17  4:48   ` Jason Cooper
2014-04-14 15:29 ` [PATCH v2 2/4] ARM: mvebu: fix NOR bus-width in Armada XP GP Device Tree Thomas Petazzoni
2014-04-17  5:08   ` Jason Cooper
2014-04-17  7:09     ` Thomas Petazzoni
2014-04-17 14:23       ` Jason Cooper
2014-04-14 15:29 ` [PATCH v2 3/4] ARM: mvebu: fix NOR bus-width in Armada XP DB " Thomas Petazzoni
2014-04-14 15:29 ` [PATCH v2 4/4] ARM: mvebu: fix NOR bus-width in Armada XP OpenBlocks AX3 " Thomas Petazzoni
2014-04-14 17:00 ` Ezequiel Garcia [this message]
2014-04-16  8:17 ` [PATCH v2 0/4] ARM: mvebu: fix bus width handling in mvebu-devbus Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140414170031.GB527@arch.cereza \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox