linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dma: fix eDMA driver as a subsys_initcall
@ 2014-04-04  4:27 Yuan Yao
  2014-04-16  6:34 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Yuan Yao @ 2014-04-04  4:27 UTC (permalink / raw)
  To: linux-arm-kernel

Because of some driver base on DMA, changed the initcall order as subsys_initcall.

Signed-off-by: Yuan Yao <yao.yuan@freescale.com>
---
 drivers/dma/fsl-edma.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/fsl-edma.c b/drivers/dma/fsl-edma.c
index 381e793..b396a7f 100644
--- a/drivers/dma/fsl-edma.c
+++ b/drivers/dma/fsl-edma.c
@@ -968,7 +968,17 @@ static struct platform_driver fsl_edma_driver = {
 	.remove		= fsl_edma_remove,
 };
 
-module_platform_driver(fsl_edma_driver);
+static int __init fsl_edma_init(void)
+{
+	return platform_driver_register(&fsl_edma_driver);
+}
+subsys_initcall(fsl_edma_init);
+
+static void __exit fsl_edma_exit(void)
+{
+	platform_driver_unregister(&fsl_edma_driver);
+}
+module_exit(fsl_edma_exit);
 
 MODULE_ALIAS("platform:fsl-edma");
 MODULE_DESCRIPTION("Freescale eDMA engine driver");
-- 
1.8.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] dma: fix eDMA driver as a subsys_initcall
  2014-04-04  4:27 [PATCH] dma: fix eDMA driver as a subsys_initcall Yuan Yao
@ 2014-04-16  6:34 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2014-04-16  6:34 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Apr 04, 2014 at 12:27:55PM +0800, Yuan Yao wrote:
> Because of some driver base on DMA, changed the initcall order as subsys_initcall.

Changelog could have mentioned "which" driver and elobrated on it
> 
> Signed-off-by: Yuan Yao <yao.yuan@freescale.com>

Applied, nevertheless

-- 
~Vinod
> ---
>  drivers/dma/fsl-edma.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/fsl-edma.c b/drivers/dma/fsl-edma.c
> index 381e793..b396a7f 100644
> --- a/drivers/dma/fsl-edma.c
> +++ b/drivers/dma/fsl-edma.c
> @@ -968,7 +968,17 @@ static struct platform_driver fsl_edma_driver = {
>  	.remove		= fsl_edma_remove,
>  };
>  
> -module_platform_driver(fsl_edma_driver);
> +static int __init fsl_edma_init(void)
> +{
> +	return platform_driver_register(&fsl_edma_driver);
> +}
> +subsys_initcall(fsl_edma_init);
> +
> +static void __exit fsl_edma_exit(void)
> +{
> +	platform_driver_unregister(&fsl_edma_driver);
> +}
> +module_exit(fsl_edma_exit);
>  
>  MODULE_ALIAS("platform:fsl-edma");
>  MODULE_DESCRIPTION("Freescale eDMA engine driver");
> -- 
> 1.8.4
> 
> 

-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-16  6:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-04  4:27 [PATCH] dma: fix eDMA driver as a subsys_initcall Yuan Yao
2014-04-16  6:34 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).