From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ahci: imx: use macros to define registers and bits
Date: Wed, 16 Apr 2014 16:08:50 +0800 [thread overview]
Message-ID: <20140416080849.GL2523@dragon> (raw)
In-Reply-To: <20140416075957.GR5969@pengutronix.de>
On Wed, Apr 16, 2014 at 09:59:57AM +0200, Uwe Kleine-K?nig wrote:
> On Tue, Apr 15, 2014 at 10:41:42AM +0800, Shawn Guo wrote:
> > diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
> > index 497c7ab..39629b4 100644
> > --- a/drivers/ata/ahci_imx.c
> > +++ b/drivers/ata/ahci_imx.c
> > @@ -28,11 +28,9 @@
> > #include <linux/libata.h>
> > #include "ahci.h"
> >
> > -enum {
> > - PORT_PHY_CTL = 0x178, /* Port0 PHY Control */
> > - PORT_PHY_CTL_PDDQ_LOC = 0x100000, /* PORT_PHY_CTL bits */
> > - HOST_TIMER1MS = 0xe0, /* Timer 1-ms */
> > -};
> > +#define IMX_SATA_TIMER1MS 0x00e0
> > +#define IMX_SATA_P0PHYCR 0x0178
> > +#define P0PHYCR_TEST_PDDQ (1 << 20)
> Did you intentionally not namespace the bit mask?
Yes, with the intention to make the bit names a little shorter.
Shawn
prev parent reply other threads:[~2014-04-16 8:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 2:41 [PATCH 1/2] ahci: imx: use macros to define registers and bits Shawn Guo
2014-04-15 2:41 ` [PATCH 2/2] ahci: imx: software workaround for phy reset issue in resume Shawn Guo
2014-04-15 3:19 ` Fabio Estevam
2014-04-15 16:10 ` Tejun Heo
2014-04-16 7:38 ` Shawn Guo
2014-04-16 14:01 ` Tejun Heo
2014-04-17 2:05 ` Shawn Guo
2014-04-15 16:03 ` [PATCH 1/2] ahci: imx: use macros to define registers and bits Tejun Heo
2014-04-16 6:35 ` Shawn Guo
2014-04-16 13:57 ` Tejun Heo
2014-04-16 7:59 ` Uwe Kleine-König
2014-04-16 8:08 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416080849.GL2523@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).