From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] thermal: armada: Support Armada 375 SoC
Date: Wed, 16 Apr 2014 12:49:27 -0300 [thread overview]
Message-ID: <20140416154927.GA1892@arch.cereza> (raw)
In-Reply-To: <20140416153819.GF28159@titan.lakedaemon.net>
Jason,
Thanks for taking a look.
On Apr 16, Jason Cooper wrote:
> On Wed, Apr 16, 2014 at 11:15:18AM -0300, Ezequiel Garcia wrote:
> > + /* This is only needed on A375 Z1 SoC silicon revision */
> > + reg |= A375_Z1_WORKAROUND_BIT;
>
> and this seem to be the only differences between the two init functions.
>
> It also appears to be the only reason for having two data structs below.
> Is it worth checking for the compatible string in the init function so
> you only have one init and one data struct?
>
Yes, thought about it at one point but I guess it seemed to me cleaner
this way.
I'll squash it if you think keeping two structs is stupid bloat.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-16 15:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:15 [PATCH 0/6] thermal: Add Armada 375 SoC support Ezequiel Garcia
2014-04-16 14:15 ` [PATCH 1/6] thermal: armada: Rename armada_thermal_ops struct Ezequiel Garcia
2014-04-16 14:15 ` [PATCH 2/6] thermal: armada: Add infrastructure to support generic formulas Ezequiel Garcia
2014-04-16 14:15 ` [PATCH 3/6] thermal: armada: Add generic infrastructure to handle the sensor Ezequiel Garcia
2014-04-16 14:15 ` [PATCH 4/6] thermal: armada: Support Armada 375 SoC Ezequiel Garcia
2014-04-16 15:38 ` Jason Cooper
2014-04-16 15:49 ` Ezequiel Garcia [this message]
2014-04-16 16:40 ` Jason Cooper
2014-04-16 15:44 ` Jason Cooper
2014-04-16 15:53 ` Ezequiel Garcia
2014-04-16 14:15 ` [PATCH 5/6] ARM: mvebu: Add thermal quirk for the Armada 375 DB board Ezequiel Garcia
2014-04-16 15:59 ` Sebastian Hesselbarth
2014-04-16 16:03 ` Thomas Petazzoni
2014-04-16 16:08 ` Andrew Lunn
2014-04-16 16:19 ` Thomas Petazzoni
2014-04-16 16:34 ` Andrew Lunn
2014-04-16 16:55 ` Jason Cooper
2014-04-16 17:08 ` Thomas Petazzoni
2014-04-16 14:15 ` [PATCH 6/6] ARM: mvebu: Enable the thermal sensor in Armada 375 SoC Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416154927.GA1892@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).