From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Wed, 16 Apr 2014 21:30:36 +0200 Subject: [PATCH] clocksource: efm32: let CLKSRC_EFM32 select CLKSRC_OF In-Reply-To: References: <1397673612-24247-1-git-send-email-u.kleine-koenig@pengutronix.de> Message-ID: <20140416193036.GS5969@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Wed, Apr 16, 2014 at 01:51:17PM -0500, Rob Herring wrote: > On Wed, Apr 16, 2014 at 1:40 PM, Uwe Kleine-K?nig > wrote: > > The efm32 timer driver is only usable with CLKSRC_OF, so it makes sense > > to let its Kconfig symbol select it. For compile coverage testing it's not > > needed though, so only select it if ARCH_EFM32 is enabled. > > > > This allows to drop ARCH_EFM32 selecting CLKSRC_OF which is done here > > for simplicity, too. > > > > Reported-by: Rob Herring > > Signed-off-by: Uwe Kleine-K?nig > > --- > > [...] > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > > --- a/drivers/clocksource/Kconfig > > +++ b/drivers/clocksource/Kconfig > > @@ -80,6 +80,7 @@ config CLKSRC_EFM32 > > bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32 > > depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST) > > select CLKSRC_MMIO > > + select CLKSRC_OF if ARCH_EFM32 > > You already depend on OF, so I believe you don't need the if here. Rob and I discussed this shortly on irc, the summary is that the if is not needed to prevent Kconfig breakage but adds more flexibility for the COMPILE_TEST case. In the end Rob said: 1397676012 < robher> you can add my ack. which would be: Acked-by: Rob Herring Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |