linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module timer node.
Date: Thu, 17 Apr 2014 16:22:34 +0800	[thread overview]
Message-ID: <20140417082228.GA22160@dragon> (raw)
In-Reply-To: <6934b6e7d11f4eb6a8ec74542820d718@BY2PR03MB505.namprd03.prod.outlook.com>

On Thu, Apr 17, 2014 at 07:49:31AM +0000, Li.Xiubo at freescale.com wrote:
> > > +			ftm0: ftm at 40038000 {
> > > +				compatible = "fsl,vf610-ftm-timer";
> > > +				reg = <0x40038000 0x2000>;
> > > +				interrupts = <0 42 IRQ_TYPE_LEVEL_HIGH>;
> > > +				clock-names = "ftm0", "ftm1",
> > > +					"ftm0_counter_en", "ftm1_counter_en";
> > > +				clocks = <&clks VF610_CLK_FTM0>,
> > > +					<&clks VF610_CLK_FTM1>,
> > > +					<&clks VF610_CLK_FTM0_EXT_FIX_EN>,
> > > +					<&clks VF610_CLK_FTM1_EXT_FIX_EN>;
> > > +				status = "disabled";
> > 
> > For such completely internal block which has no pins route out on board,
> > we should probably just not have this "disabled" status line.
> > 
> 
> Well, from IEEE 1275, there defined a standard 'status' property indicating
> The operational status of one device. The 'status' property has four possible
> values: 'okay/ok', 'disabled', 'fail' and 'fail-xxx'.
> 
> If it is absent, that means the status of the device is unknown or okay.

Yes, missing 'disabled' status equals to a 'okay' status from Linux
implementation.  Then, the device is always available in device tree,
and Linux Kconfig option will control whether the driver for the device
is enabled.

> 
> If discard the status line here in vf610.dtsi, this device will be enabled
> as default though 'no pins route out' on the board, and actually there has
> pins route out on the board, as timer devices here we just not use it, but
> as PWM devices the pins will be used.
> 
> How about let the node disabled in vf610.dtsi, and then enable it in vf610-twr.dts
> if it will be used in TWR board... ?

Okay.  If there is some use cases that have board level configuration
like pin out, I'm fine with your existing code.

Shawn

  reply	other threads:[~2014-04-17  8:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16  2:19 [RFC][PATCH 0/3] Add Freescale FlexTimer Module timer Xiubo Li
2014-04-16  2:19 ` [RFC][PATCH 1/3] ARM: dts: vf610: Add Freescale FlexTimer Module timer node Xiubo Li
2014-04-16  4:00   ` Dongsheng.Wang at freescale.com
2014-04-16  6:08     ` Li.Xiubo at freescale.com
2014-04-16  8:59   ` Shawn Guo
2014-04-16  9:39     ` Li.Xiubo at freescale.com
2014-04-17  7:49     ` Li.Xiubo at freescale.com
2014-04-17  8:22       ` Shawn Guo [this message]
2014-04-17  8:34         ` Li.Xiubo at freescale.com
2014-04-16  9:08   ` Daniel Lezcano
2014-04-16  9:38     ` Li.Xiubo at freescale.com
2014-04-16  2:19 ` [RFC][PATCH 2/3] ARM: dts: vf610-twr: Enable Freescale FlexTimer Module timer Xiubo Li
2014-04-16  2:19 ` [RFC][PATCH 3/3] clocksource: Add Freescale FlexTimer Module (FTM) timer support Xiubo Li
2014-04-16  3:18   ` Dongsheng.Wang at freescale.com
2014-04-16  3:45     ` Li.Xiubo at freescale.com
2014-04-17 14:22   ` Daniel Lezcano
2014-04-18  3:47     ` Li.Xiubo at freescale.com
2014-04-18  3:55     ` Li.Xiubo at freescale.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140417082228.GA22160@dragon \
    --to=shawn.guo@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).