From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ASoC: alc5623: Add device tree binding
Date: Fri, 18 Apr 2014 17:33:51 +0100 [thread overview]
Message-ID: <20140418163351.GI12304@sirena.org.uk> (raw)
In-Reply-To: <1397749994-24983-2-git-send-email-andrew@lunn.ch>
On Thu, Apr 17, 2014 at 05:53:10PM +0200, Andrew Lunn wrote:
> + - compatible: "realtek,alc5623"
You've not added an ID table to the driver for this.
> + - add-ctrl: Default register value for Reg-40h, Additional Control Register.
> + If absent, the default is 0.
> + - jack-det-ctrl: Default register value for Reg-5Ah, Jack Detect
> + Control Register. If absent, the default is 0.
I would expect the default for these to be to leave the hardware
defaults untouched - why is it different, what does setting to zero mean?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140418/055b6a53/attachment.sig>
next prev parent reply other threads:[~2014-04-18 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 15:53 [PATCH 0/5] Simple-audio-card support for HP t5325 Andrew Lunn
2014-04-17 15:53 ` [PATCH 1/5] ASoC: alc5623: Add device tree binding Andrew Lunn
2014-04-18 16:33 ` Mark Brown [this message]
2014-04-18 18:17 ` Andrew Lunn
2014-04-18 18:44 ` Mark Brown
2014-04-17 15:53 ` [PATCH 2/5] ARM: Kirkwood: Use DT to instansiate codec Andrew Lunn
2014-04-17 21:37 ` Jason Cooper
2014-04-17 15:53 ` [PATCH 3/5] ARM: Kirkwood: DT: Add missing #sound-dai-cells property Andrew Lunn
2014-04-17 15:53 ` [PATCH 4/5] ASoC: simple-card: Support setting mclk via a fixed factor Andrew Lunn
2014-04-18 16:38 ` Mark Brown
2014-04-17 15:53 ` [PATCH 5/5] ARM: Kirkwood: t5325: Use simple-card to instantiate audio Andrew Lunn
2014-04-18 0:15 ` [PATCH 0/5] Simple-audio-card support for HP t5325 Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418163351.GI12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox