From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: Kirkwood: Add board file for netxbig LEDs
Date: Fri, 18 Apr 2014 20:07:23 +0200 [thread overview]
Message-ID: <20140418180723.GA32580@lunn.ch> (raw)
In-Reply-To: <20140418132148.GX28159@titan.lakedaemon.net>
On Fri, Apr 18, 2014 at 09:21:48AM -0400, Jason Cooper wrote:
> On Thu, Apr 17, 2014 at 06:08:55PM +0200, Andrew Lunn wrote:
> > There is currently no DT binding for the CPLD which controls the LEDs
> > on the Net 2Big and Net 5Big. So use a platform device.
> >
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > ---
> > arch/arm/mach-mvebu/Kconfig | 7 ++
> > arch/arm/mach-mvebu/Makefile | 1 +
> > arch/arm/mach-mvebu/board-netxbig.c | 191 ++++++++++++++++++++++++++++++++++++
>
> This seems pretty simple. What's preventing this from becoming a
> full-fledged driver under drivers/leds?
It is. See drivers/leds/leds-netxbig.c
We can add a DT binding as the next step, in the same way that we are
converting T5325 audio by adding a binding to the codec. Simon also
said that they have an Intel platform also using the same driver, and
he would like to consider how that would work, DT, ACPI, etc. Once
Simon is back from vacation, we can figure out a binding.
Andrew
next prev parent reply other threads:[~2014-04-18 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 16:08 [PATCH 0/4] Add a DT description of LaCie 2Big and 5Big Network v2 Andrew Lunn
2014-04-17 16:08 ` [PATCH 1/4] ARM: Kirkwood: Add board file for netxbig LEDs Andrew Lunn
2014-04-18 13:21 ` Jason Cooper
2014-04-18 18:07 ` Andrew Lunn [this message]
2014-04-17 16:08 ` [PATCH 2/4] ARM: Kirkwood: Add DT descriptions for net2big and net5big Andrew Lunn
2014-04-17 18:08 ` Simon Guinot
2014-04-17 16:08 ` [PATCH 3/4] ARM: MVEBU: Add LaCie 2Big and 5Big Network v2 Andrew Lunn
2014-04-17 16:22 ` Gregory CLEMENT
2014-04-18 13:29 ` Jason Cooper
2014-04-17 16:08 ` [PATCH 4/4] ARM: MULTI_V5: Enable " Andrew Lunn
2014-04-17 17:56 ` [PATCH 0/4] Add a DT description of " Simon Guinot
2014-04-18 13:31 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418180723.GA32580@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).