From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Better virt_to_page() handling
Date: Tue, 22 Apr 2014 16:55:14 -0300 [thread overview]
Message-ID: <20140422195514.GA13106@arch.cereza> (raw)
In-Reply-To: <E1WTYiT-0007Jl-Fe@rmk-PC.arm.linux.org.uk>
Russell,
On Mar 28, Russell King wrote:
> -#ifndef __virt_to_phys
> -#ifdef CONFIG_ARM_PATCH_PHYS_VIRT
> +#if defined(__virt_to_phys)
> +#define PHYS_OFFSET PLAT_PHYS_OFFSET
> +#define PHYS_PFN_OFFSET ((unsigned long)(PHYS_OFFSET >> PAGE_SHIFT))
> +
> +#define virt_to_pfn(kaddr) (__pa(kaddr) >> PAGE_SHIFT)
> +
Building 20140422 -next produces a myriad of these warnings:
[..]
CC fs/mpage.o
In file included from /home/zeta/linux/next/arch/arm/include/asm/page.h:163:0,
from include/linux/mmzone.h:20,
from include/linux/gfp.h:5,
from include/linux/mm.h:9,
from fs/mpage.c:17:
/home/zeta/linux/next/arch/arm/include/asm/memory.h:297:0: warning: "virt_to_pfn" redefined [enabled by default]
#define virt_to_pfn(kaddr) (__pa(kaddr) >> PAGE_SHIFT)
^
/home/zeta/linux/next/arch/arm/include/asm/memory.h:194:0: note: this is the location of the previous definition
#define virt_to_pfn(kaddr) \
^
I saw you already answered Nicolas about the double-definition, so I'm merely
reporting the build gets really spammy now. (Although I guess you already
noticed this)
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-22 19:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 15:28 __pv_phys_offset, inline assembly functions, and such like Russell King - ARM Linux
2014-03-28 15:29 ` [PATCH] ARM: Better virt_to_page() handling Russell King
2014-03-28 19:52 ` Nicolas Pitre
2014-03-28 20:05 ` Russell King - ARM Linux
2014-03-29 2:51 ` Nicolas Pitre
2014-04-22 19:55 ` Ezequiel Garcia [this message]
2014-04-23 7:35 ` [PATCH] ARM: Fix double definition of virt_to_pfn() Peter Ujfalusi
2014-04-23 9:37 ` Russell King - ARM Linux
2014-04-23 10:40 ` Peter Ujfalusi
2014-03-28 16:44 ` __pv_phys_offset, inline assembly functions, and such like Arnd Bergmann
2014-03-28 16:56 ` Russell King - ARM Linux
2014-03-28 17:39 ` Arnd Bergmann
2014-04-04 22:32 ` [PATCH] ARM: Better virt_to_page() handling Russell King
2014-04-04 22:44 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422195514.GA13106@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox