public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled
Date: Thu, 24 Apr 2014 23:18:35 -0300	[thread overview]
Message-ID: <20140425021835.GA590@arch.cereza> (raw)
In-Reply-To: <1398339276-5754-1-git-send-email-ezequiel.garcia@free-electrons.com>

Jason,

On Apr 24, Ezequiel Garcia wrote:
> HAVE_ARM_TWD depends on SMP, so we should only select it if
> SMP is enabled, as the others platforms do.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
>  arch/arm/mach-mvebu/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 7bb92b1..8c9fd60 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -41,7 +41,7 @@ config MACH_ARMADA_375
>  	select ARMADA_375_CLK
>  	select CPU_V7
>  	select HAVE_ARM_SCU
> -	select HAVE_ARM_TWD
> +	select HAVE_ARM_TWD if SMP
>  	select HAVE_SMP
>  	select MACH_MVEBU_V7
>  	select PINCTRL_ARMADA_375
> @@ -57,7 +57,7 @@ config MACH_ARMADA_38X
>  	select ARMADA_38X_CLK
>  	select CPU_V7
>  	select HAVE_ARM_SCU
> -	select HAVE_ARM_TWD
> +	select HAVE_ARM_TWD if SMP
>  	select HAVE_SMP
>  	select MACH_MVEBU_V7
>  	select PINCTRL_ARMADA_38X
> -- 
> 1.9.1
> 

As pointed out by Thomas, this fixes a build break when SMP=n. Maybe you can
merge it sooner than later?
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

  reply	other threads:[~2014-04-25  2:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 11:34 [PATCH] ARM: mvebu: Select HAVE_ARM_TWD only if SMP is enabled Ezequiel Garcia
2014-04-25  2:18 ` Ezequiel Garcia [this message]
2014-04-25 21:26 ` Jason Cooper
2014-04-25 21:37   ` Ezequiel Garcia
2014-04-25 21:42     ` Jason Cooper
2014-04-26  0:46 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140425021835.GA590@arch.cereza \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox