From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] power: twl4030_charger: clear IRQs after handling them
Date: Fri, 25 Apr 2014 16:00:36 -0500 [thread overview]
Message-ID: <20140425210036.GO29632@saruman.home> (raw)
In-Reply-To: <535ACC62.102@ti.com>
On Fri, Apr 25, 2014 at 03:58:10PM -0500, Nishanth Menon wrote:
> On 04/16/2014 11:35 AM, Tony Lindgren wrote:
> > * Felipe Balbi <balbi@ti.com> [140416 08:18]:
> >> TRM says we *must* write 1 to each bit we're handling
> >> in order to clear the IRQ status and bring IRQ line
> >> low. This patch implements that.
> >>
> >> Signed-off-by: Felipe Balbi <balbi@ti.com>
> >> ---
> >>
> >> Russell, I don't have HW to test, but this should
> >> solve the problem you saw when not using battery
> >> with Zoom board. Let me know if it doesn't.
> >
> > BTW, looks like we're enabling BCI automatically in twl4030.dtsi
> > while the legacy booting does not have TWL_COMMON_PDATA_BCI
> > enabled for LDP. Anyways, for LDP BCI should be enabled for
> > sure, that's the only way to power at least the earlier LDP
> > revisions.
> >
> I picked up https://patchwork.kernel.org/patch/4002371/ for testing.
>
> Unfortunately, it does not seem to work in my tests:
alright, I'll have a look after I get this other issue out of the way.
Probably not until next week.
> This patch should probably also acknowledge that Russell reported this
> issue.
sure I can add that, although it doesn't solve anything as it is ...
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140425/57d54cb0/attachment.sig>
next prev parent reply other threads:[~2014-04-25 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 15:14 [PATCH] power: twl4030_charger: clear IRQs after handling them Felipe Balbi
2014-04-16 16:35 ` Tony Lindgren
2014-04-25 20:58 ` Nishanth Menon
2014-04-25 21:00 ` Felipe Balbi [this message]
2014-05-07 0:24 ` Nishanth Menon
2014-05-09 1:03 ` Tony Lindgren
2014-05-09 12:39 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425210036.GO29632@saruman.home \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).