From mboxrd@z Thu Jan 1 00:00:00 1970 From: balbi@ti.com (Felipe Balbi) Date: Mon, 28 Apr 2014 09:31:15 -0500 Subject: [PATCH 1/6] drivers: net: cpts: Remove hardcoded clock name for CPTS In-Reply-To: <1398658225-25873-2-git-send-email-george.cherian@ti.com> References: <1398658225-25873-1-git-send-email-george.cherian@ti.com> <1398658225-25873-2-git-send-email-george.cherian@ti.com> Message-ID: <20140428143115.GC30292@saruman.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 28, 2014 at 09:40:20AM +0530, George Cherian wrote: > CPTS refclk name is hardcoded, which makes it fail in case of DRA7x > Remove the hardcoded clock name for CPTS refclk and get the same from DT. > > Signed-off-by: George Cherian > --- > drivers/net/ethernet/ti/cpts.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c > index 2435139..0b6f6f7 100644 > --- a/drivers/net/ethernet/ti/cpts.c > +++ b/drivers/net/ethernet/ti/cpts.c > @@ -236,13 +236,11 @@ static void cpts_overflow_check(struct work_struct *work) > schedule_delayed_work(&cpts->overflow_work, CPTS_OVERFLOW_PERIOD); > } > > -#define CPTS_REF_CLOCK_NAME "cpsw_cpts_rft_clk" > - > -static void cpts_clk_init(struct cpts *cpts) > +static void cpts_clk_init(struct device *dev, struct cpts *cpts) > { > - cpts->refclk = clk_get(NULL, CPTS_REF_CLOCK_NAME); > + cpts->refclk = devm_clk_get(dev, "cpts"); > if (IS_ERR(cpts->refclk)) { > - pr_err("Failed to clk_get %s\n", CPTS_REF_CLOCK_NAME); > + pr_err("Failed to get cpts refclk\n"); now you have a dev pointer as argument, how about converting this to dev_err() ? -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: