From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: put_user: fix possible data corruption in put_user
Date: Mon, 5 May 2014 10:01:26 +0100 [thread overview]
Message-ID: <20140505090126.GD3693@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1399270438-26181-1-git-send-email-a.ryabinin@samsung.com>
On Mon, May 05, 2014 at 10:13:58AM +0400, Andrey Ryabinin wrote:
> According to arm procedure call standart r2 register is call-cloberred.
> So after the result of x expression was put into r2 any following
> function call in p may overwrite r2. To fix this, the result of p
> expression must be saved to the temporary variable before the
> assigment x expression to __r2.
This and the patch make no sense. You talk about r2, but you're doing
nothing with r2 in the patch.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-05-05 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 6:13 [PATCH] arm: put_user: fix possible data corruption in put_user Andrey Ryabinin
2014-05-05 9:01 ` Russell King - ARM Linux [this message]
2014-05-05 10:50 ` Andrey Ryabinin
2014-05-05 13:45 ` Nicolas Pitre
2014-05-05 14:15 ` Nicolas Pitre
2014-05-06 7:11 ` [PATCHv2] " Andrey Ryabinin
2014-05-06 20:13 ` Nicolas Pitre
2014-05-07 13:19 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505090126.GD3693@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox