[PATCH V2 04/19] bus: omap_l3_noc: populate l3->dev and use it

Nishanth Menon
2014-04-17T20:49:20Z

l3->dev is not populated, so populate it and use it to print information
relevant to the device instead of using a generic pr_*.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
v2: reordering, dropped the warn change as centralizing patch follows
v1: https://patchwork.kernel.org/patch/3984221/
drivers/bus/omap_l3_noc.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/bus/omap_l3_noc.c b/drivers/bus/omap_l3_noc.c
index 800486c..37d71b7 100644
--- a/drivers/bus/omap_l3_noc.c
+++ b/drivers/bus/omap_l3_noc.c
@@ -131,6 +131,7 @@ static int omap_l3_probe(struct platform_device *pdev)
if (!l3)
return -ENOMEM;

+ l3->dev = &pdev->dev;
platform_set_drvdata(pdev, l3);

/* Get mem resources */
@@ -140,7 +141,7 @@ static int omap_l3_probe(struct platform_device *pdev)

l3->l3_base[i] = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(l3->l3_base[i])) {
- dev_err(&pdev->dev, "ioremap %d failed\n", i);
+ dev_err(l3->dev, "ioremap %d failed\n", i);
return PTR_ERR(l3->l3_base[i]);
}
}
@@ -149,19 +150,19 @@ static int omap_l3_probe(struct platform_device *pdev)
* Setup interrupt Handlers
*/
l3->debug_irq = platform_get_irq(pdev, 0);
- ret = devm_request_irq(&pdev->dev, l3->debug_irq, l3_interrupt_handler,
+ ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler,
IRQF_DISABLED, "l3-dbg-irq", l3);
if (ret) {
- dev_err(&pdev->dev, "request_irq failed for %d\n",
+ dev_err(l3->dev, "request_irq failed for %d\n",
l3->debug_irq);
return ret;
}

l3->app_irq = platform_get_irq(pdev, 1);
- ret = devm_request_irq(&pdev->dev, l3->app_irq, l3_interrupt_handler,
+ ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler,
IRQF_DISABLED, "l3-app-irq", l3);
if (ret)
- dev_err(&pdev->dev, "request_irq failed for %d\n", l3->app_irq);
+ dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq);

return ret;
}
--
1.7.9.5