* [PATCH] ARM: dts: i.MX53: Fix ipu register space size
@ 2014-05-06 11:01 Sascha Hauer
2014-05-06 11:49 ` Lothar Waßmann
2014-05-06 12:58 ` Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Sascha Hauer @ 2014-05-06 11:01 UTC (permalink / raw)
To: linux-arm-kernel
The IPU register space is 128MB, not 2GB.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/boot/dts/imx53.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index 9c2bff2..6a1bf4f 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -115,7 +115,7 @@
#address-cells = <1>;
#size-cells = <0>;
compatible = "fsl,imx53-ipu";
- reg = <0x18000000 0x080000000>;
+ reg = <0x18000000 0x08000000>;
interrupts = <11 10>;
clocks = <&clks IMX5_CLK_IPU_GATE>,
<&clks IMX5_CLK_IPU_DI0_GATE>,
--
2.0.0.rc0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: i.MX53: Fix ipu register space size
2014-05-06 11:01 [PATCH] ARM: dts: i.MX53: Fix ipu register space size Sascha Hauer
@ 2014-05-06 11:49 ` Lothar Waßmann
2014-05-06 12:00 ` Sascha Hauer
2014-05-06 12:58 ` Shawn Guo
1 sibling, 1 reply; 7+ messages in thread
From: Lothar Waßmann @ 2014-05-06 11:49 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Sascha Hauer wrote:
> The IPU register space is 128MB, not 2GB.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/boot/dts/imx53.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index 9c2bff2..6a1bf4f 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -115,7 +115,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "fsl,imx53-ipu";
> - reg = <0x18000000 0x080000000>;
> + reg = <0x18000000 0x08000000>;
>
IMO this should be either 0x00800000 or 0x800000
while I prefer the first notation.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: i.MX53: Fix ipu register space size
2014-05-06 11:49 ` Lothar Waßmann
@ 2014-05-06 12:00 ` Sascha Hauer
2014-05-06 12:02 ` Sascha Hauer
0 siblings, 1 reply; 7+ messages in thread
From: Sascha Hauer @ 2014-05-06 12:00 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 06, 2014 at 01:49:43PM +0200, Lothar Wa?mann wrote:
> Hi,
>
> Sascha Hauer wrote:
> > The IPU register space is 128MB, not 2GB.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx53.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > index 9c2bff2..6a1bf4f 100644
> > --- a/arch/arm/boot/dts/imx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53.dtsi
> > @@ -115,7 +115,7 @@
> > #address-cells = <1>;
> > #size-cells = <0>;
> > compatible = "fsl,imx53-ipu";
> > - reg = <0x18000000 0x080000000>;
> > + reg = <0x18000000 0x08000000>;
> >
> IMO this should be either 0x00800000 or 0x800000
> while I prefer the first notation.
Look again, the original size is 9 digits wide: 0x0_8000_0000. I
changed this to 0x_08000_0000 which is 8 digits wide.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: i.MX53: Fix ipu register space size
2014-05-06 12:00 ` Sascha Hauer
@ 2014-05-06 12:02 ` Sascha Hauer
0 siblings, 0 replies; 7+ messages in thread
From: Sascha Hauer @ 2014-05-06 12:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 06, 2014 at 02:00:02PM +0200, Sascha Hauer wrote:
> On Tue, May 06, 2014 at 01:49:43PM +0200, Lothar Wa?mann wrote:
> > Hi,
> >
> > Sascha Hauer wrote:
> > > The IPU register space is 128MB, not 2GB.
> > >
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > > arch/arm/boot/dts/imx53.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > > index 9c2bff2..6a1bf4f 100644
> > > --- a/arch/arm/boot/dts/imx53.dtsi
> > > +++ b/arch/arm/boot/dts/imx53.dtsi
> > > @@ -115,7 +115,7 @@
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > > compatible = "fsl,imx53-ipu";
> > > - reg = <0x18000000 0x080000000>;
> > > + reg = <0x18000000 0x08000000>;
> > >
> > IMO this should be either 0x00800000 or 0x800000
> > while I prefer the first notation.
>
> Look again, the original size is 9 digits wide: 0x0_8000_0000. I
> changed this to 0x_08000_0000 which is 8 digits wide.
Argh. I meant 0x_0800_0000
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: i.MX53: Fix ipu register space size
2014-05-06 11:01 [PATCH] ARM: dts: i.MX53: Fix ipu register space size Sascha Hauer
2014-05-06 11:49 ` Lothar Waßmann
@ 2014-05-06 12:58 ` Shawn Guo
2014-05-11 3:20 ` Olof Johansson
1 sibling, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2014-05-06 12:58 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 06, 2014 at 01:01:34PM +0200, Sascha Hauer wrote:
> The IPU register space is 128MB, not 2GB.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@freescale.com>
Arnd, Olof,
Please apply this fix for 3.15, and copy stable. Thanks.
Cc: <stable@vger.kernel.org>
Shawn
> ---
> arch/arm/boot/dts/imx53.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index 9c2bff2..6a1bf4f 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -115,7 +115,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
> compatible = "fsl,imx53-ipu";
> - reg = <0x18000000 0x080000000>;
> + reg = <0x18000000 0x08000000>;
> interrupts = <11 10>;
> clocks = <&clks IMX5_CLK_IPU_GATE>,
> <&clks IMX5_CLK_IPU_DI0_GATE>,
> --
> 2.0.0.rc0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: i.MX53: Fix ipu register space size
2014-05-06 12:58 ` Shawn Guo
@ 2014-05-11 3:20 ` Olof Johansson
2014-05-11 4:42 ` Shawn Guo
0 siblings, 1 reply; 7+ messages in thread
From: Olof Johansson @ 2014-05-11 3:20 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 06, 2014 at 08:58:04PM +0800, Shawn Guo wrote:
> On Tue, May 06, 2014 at 01:01:34PM +0200, Sascha Hauer wrote:
> > The IPU register space is 128MB, not 2GB.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> Acked-by: Shawn Guo <shawn.guo@freescale.com>
>
> Arnd, Olof,
>
> Please apply this fix for 3.15, and copy stable. Thanks.
>
> Cc: <stable@vger.kernel.org>
>
Applied, but in the future please resend the whole patch since we just
get this acked-by email in the arm at kernel.org mailboxes and have to hunt
around for the original patch.
Btw for the future, this is the case where a Fixes: <12-digit sha> '<patch
subject>' would be useful, so that stable knows how far to backport. I added it
this time as well, feel free to do it yourself next time :)
-Olof
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: i.MX53: Fix ipu register space size
2014-05-11 3:20 ` Olof Johansson
@ 2014-05-11 4:42 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2014-05-11 4:42 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, May 10, 2014 at 08:20:39PM -0700, Olof Johansson wrote:
> On Tue, May 06, 2014 at 08:58:04PM +0800, Shawn Guo wrote:
> > On Tue, May 06, 2014 at 01:01:34PM +0200, Sascha Hauer wrote:
> > > The IPU register space is 128MB, not 2GB.
> > >
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > Acked-by: Shawn Guo <shawn.guo@freescale.com>
> >
> > Arnd, Olof,
> >
> > Please apply this fix for 3.15, and copy stable. Thanks.
> >
> > Cc: <stable@vger.kernel.org>
> >
>
> Applied, but in the future please resend the whole patch since we just
> get this acked-by email in the arm at kernel.org mailboxes and have to hunt
> around for the original patch.
>
> Btw for the future, this is the case where a Fixes: <12-digit sha> '<patch
> subject>' would be useful, so that stable knows how far to backport. I added it
> this time as well, feel free to do it yourself next time :)
Noted. Thanks, Olof.
Shawn
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-05-11 4:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 11:01 [PATCH] ARM: dts: i.MX53: Fix ipu register space size Sascha Hauer
2014-05-06 11:49 ` Lothar Waßmann
2014-05-06 12:00 ` Sascha Hauer
2014-05-06 12:02 ` Sascha Hauer
2014-05-06 12:58 ` Shawn Guo
2014-05-11 3:20 ` Olof Johansson
2014-05-11 4:42 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).