From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: Add CAN support
Date: Tue, 6 May 2014 22:59:17 +0200 [thread overview]
Message-ID: <20140506225917.6a291373@e6520eb> (raw)
In-Reply-To: <CAOMZO5DZFfC1NTF3gWGpCVwkOnzUi9npsLkPZioYrvDSKbFVGw@mail.gmail.com>
Hi Fabio,
Le Tue, 6 May 2014 17:04:44 -0300,
Fabio Estevam <festevam@gmail.com> a ?crit :
>
> On Tue, May 6, 2014 at 4:32 PM, Alexander Shiyan <shc_work@mail.ru> wrote:
> >> + can0: can at 0 {
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_can>;
> >> + compatible = "microchip,mcp2515";
> >> + reg = <0>;
> >> + clocks = <&clk24M>;
> >> + spi-max-frequency = <1000000>;
> >
> > This should be of course 10000000, or removed completely
> > since driver already applies such limitation to the SPI bus.
> > I think Shawn can fix this during commit.
>
> Yes, this should be 10MHz.
>
> Thanks for the review.
>
> Eric,
>
> I forgot to Cc you on v4. Besides the 10MHz error above, does it look good?
seems fine. We will test asap.
Thanks,
Eric
prev parent reply other threads:[~2014-05-06 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 19:21 [PATCH v4 1/2] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: Add CAN support Fabio Estevam
2014-05-06 19:32 ` Alexander Shiyan
2014-05-06 20:04 ` Fabio Estevam
2014-05-06 20:16 ` Alexander Shiyan
2014-05-06 20:59 ` Eric Bénard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506225917.6a291373@e6520eb \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).