From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: Disable preemption along with interrupts during shutdown
Date: Thu, 8 May 2014 16:22:20 +0100 [thread overview]
Message-ID: <20140508152220.GG3693@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAKZGPAMwqWP44Cv7V11Q+8Ykdt=3huFCRi-eKKSt5d9zPp8H+w@mail.gmail.com>
On Thu, May 08, 2014 at 07:46:21PM +0530, Arun KS wrote:
> What if we fall in a path which calls spin_unlock_irq().
> Interrupts will get enabled and only preempt_count will help to bail
> out early from preempt_schedule().
> I recently hit a similar situation.
Use of spin_lock_irq()..spin_unlock_irq() in code which was entered with
interrupts already disabled is a bug in itself.
Papering over it with preempt_disable() is not an option. /Always/ fix
the real problem, never paper over stuff like this.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-05-08 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:23 ARM: Disable preemption along with interrupts during shutdown arunks.linux at gmail.com
2014-05-08 13:49 ` Russell King - ARM Linux
2014-05-08 14:16 ` Arun KS
2014-05-08 15:22 ` Russell King - ARM Linux [this message]
2014-05-09 2:43 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508152220.GG3693@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).