From mboxrd@z Thu Jan 1 00:00:00 1970 From: ckeepax@opensource.wolfsonmicro.com (Charles Keepax) Date: Thu, 8 May 2014 17:19:14 +0100 Subject: [PATCH] regulator: arizona-ldo1: add missing #include In-Reply-To: <1399560990-1402858-19-git-send-email-arnd@arndb.de> References: <1399560433-1402630-1-git-send-email-arnd@arndb.de> <1399560990-1402858-1-git-send-email-arnd@arndb.de> <1399560990-1402858-19-git-send-email-arnd@arndb.de> Message-ID: <20140508161914.GC25203@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 08, 2014 at 04:56:30PM +0200, Arnd Bergmann wrote: > commit 2cce4be9e6b8 "regulator: arizona-ldo1: Add processing of init_data > from device tree" added a call to of_get_child_by_name() but > did not add an #include to the header file declaring that function. > > I got a build error when doing randconfig testing on this, which > is fixed by this patch to include of.h. > > drivers/regulator/arizona-ldo1.c:192:2: error: implicit declaration of function 'of_get_child_by_name' [-Werror=implicit-function-declaration] > drivers/regulator/arizona-ldo1.c:193:2: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration] > drivers/regulator/arizona-ldo1.c:213:2: error: implicit declaration of function 'of_node_put' [-Werror=implicit-function-declaration] > > Signed-off-by: Arnd Bergmann > Cc: Charles Keepax > Cc: Mark Brown > --- Thanks, yeah seems that is getting implicitly through another header included in my config. Will need a similar fix for arizona-micsupp, I will get one out for that. Reviewed-by: Charles Keepax Thanks, Charles