linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: Adding esdhc4 eMMC support on mx6sabresd
Date: Fri, 9 May 2014 10:24:50 +0800	[thread overview]
Message-ID: <20140509022448.GA10730@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <20140509031624.GL2794@dragon>

On Fri, May 09, 2014 at 11:16:25AM +0800, Shawn Guo wrote:
> On Thu, May 08, 2014 at 06:17:32PM +0800, Dong Aisheng wrote:
> > I just tested an old Chris/mmc-next tree which is 3.14 rc2 with the top commit is b42b9b.
> > The eMMC works well on SabreSD boards.
> > But it failed and got the same issue with latest chris/mmc-next tree.
> > I noticed there's no changes on sdhci-esdhc-imx.c
> > Probably some other changes breaks this function.
> > 
> > Fabio,
> > You may bisect it yourself or i will do it later when i'm a bit free.
> 
> The regression is caused by the following commit ...
> 
> commit 79f7ae7c45a6ccf04e2908337461dee615f6afb0
> Author: Seungwon Jeon <tgih.jun@samsung.com>
> Date:   Fri Mar 14 21:11:56 2014 +0900
> 
>     mmc: clarify DDR timing mode between SD-UHS and eMMC
> 
>     This change distinguishes DDR timing mode of current
>     mixed usage to clarify device type.
> 
>     Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>     Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
>     Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>     Signed-off-by: Chris Ball <chris@printf.net>
> 
> ... and the line below.
>  
> @@ -1264,7 +1264,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>                                         goto err;
>                         }
>                         mmc_card_set_ddr_mode(card);
> -                       mmc_set_timing(card->host, MMC_TIMING_UHS_DDR50);
> +                       mmc_set_timing(card->host, MMC_TIMING_MMC_DDR52);
>                         mmc_set_bus_width(card->host, bus_width);
>                 }
>         }
> 

Thanks for the info.
The plat driver is still using UHS_DDR50 which may need update too.
I will submit a patch to fix it ASAP.

Regards
Dong Aisheng

> 
> > Shawn,
> > I remember this patch should have been upstream through your tree long time ago.
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/206446.html
> > It seems somehow missed.
> 
> Ah, yes.  It got lost.
> 
> Shawn

  reply	other threads:[~2014-05-09  2:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 20:14 Adding esdhc4 eMMC support on mx6sabresd Fabio Estevam
2014-05-08  7:18 ` Lothar Waßmann
2014-05-08 10:17   ` Dong Aisheng
2014-05-08 14:05     ` Fabio Estevam
2014-05-09  3:16     ` Shawn Guo
2014-05-09  2:24       ` Dong Aisheng [this message]
     [not found] <CAKVbgXpn43n-8Azjc9f2-RHw51uVAAKkv_dT7b_iXWxNm7q+Qw@mail.gmail.com>
2014-11-18 15:02 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140509022448.GA10730@shlinux1.ap.freescale.net \
    --to=b29396@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).