[PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt

Simon Horman
2014-05-11T00:08:35Z

On Sat, May 10, 2014 at 02:59:15AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 05/09/2014 09:06 AM, Wolfram Sang wrote:
>
> >>>+ eeprom at 50 {
> >>>+ compatible = "renesas,24c02";
>
> >> This is not quite right: Renesas' part is called differently, and
> >>you're carrying the other vendor's naming onto Renesas parts. I'd
> >>just say "24c02" (which I'll do in the Henninger board patch).
>
> >What about "generic"?
>
> I don't know, really. However, you're right in that there should
> be some vendor prefix -- I've just seen
> Documentation/devicetree/bindings/eeprom.txt.

A quick survey of arch/arm/boot/dts/ yields:

"atmel,24c02" (22 times)
"microchip,24c02" (once)
"mcp,24c02" (once)

So it seems to me that precedence is in favour of using "renesas,24c02".