[PATCH V2 2/2] ARM: shmobile: r8a7791: add i2c2 bus to koelsch dt

Geert Uytterhoeven
2014-05-12T07:35:46Z

On Sun, May 11, 2014 at 2:08 AM, Simon Horman <horms@verge.net.au> wrote:
> On Sat, May 10, 2014 at 02:59:15AM +0400, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 05/09/2014 09:06 AM, Wolfram Sang wrote:
>>
>> >>>+ eeprom at 50 {
>> >>>+ compatible = "renesas,24c02";
>>
>> >> This is not quite right: Renesas' part is called differently, and
>> >>you're carrying the other vendor's naming onto Renesas parts. I'd
>> >>just say "24c02" (which I'll do in the Henninger board patch).
>>
>> >What about "generic"?
>>
>> I don't know, really. However, you're right in that there should
>> be some vendor prefix -- I've just seen
>> Documentation/devicetree/bindings/eeprom.txt.
>
> A quick survey of arch/arm/boot/dts/ yields:
>
> "atmel,24c02" (22 times)
> "microchip,24c02" (once)
> "mcp,24c02" (once)
>
> So it seems to me that precedence is in favour of using "renesas,24c02".

Except that the Renesas part is called differently (as Sergei already pointed
out), unlike the Atmel and Microchip parts.

So it should be:

compatible = "renesas,r1ex24002", "<something>,24c02";

Unfortunately the datasheet doesn't mention compatibility with parts from
other manufacturers.

So let's <something> be "atmel"?

BTW, we have a similar issue with Genmai, which has an R1EX24128.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds