linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: dts: Karo TX25: Add phy reset gpio and supply for FEC
Date: Fri, 9 May 2014 08:11:58 +0200	[thread overview]
Message-ID: <20140509061158.GP5858@pengutronix.de> (raw)
In-Reply-To: <20140508142742.23e78575@ipc1.ka-ro>

Hi Lothar,

On Thu, May 08, 2014 at 02:27:42PM +0200, Lothar Wa?mann wrote:
> Hi,
> 
> Sascha Hauer wrote:
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx25-karo-tx25.dts | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx25-karo-tx25.dts b/arch/arm/boot/dts/imx25-karo-tx25.dts
> > index aeb1fce..ea7dddc 100644
> > --- a/arch/arm/boot/dts/imx25-karo-tx25.dts
> > +++ b/arch/arm/boot/dts/imx25-karo-tx25.dts
> > @@ -16,6 +16,21 @@
> >  	model = "Ka-Ro TX25";
> >  	compatible = "karo,imx25-tx25", "fsl,imx25";
> >  
> > +	regulators {
> > +		compatible = "simple-bus";
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		reg_fec_phy: regulator at 0 {
> > +			compatible = "regulator-fixed";
> > +			reg = <0>;
> > +			regulator-name = "fec-phy";
> > +			regulator-min-microvolt = <3300000>;
> > +			regulator-max-microvolt = <3300000>;
> > +			gpio = <&gpio4 9 0>;
> >
> 			enable-active-high;
> missing here.
> 
> > +		};
> > +	};
> > +
> >  	memory {
> >  		reg = <0x80000000 0x02000000 0x90000000 0x02000000>;
> >  	};
> > @@ -77,7 +92,9 @@
> >  &fec {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_fec>;
> > +	phy-reset-gpios = <&gpio4 7 0>;
> >
> This must be: <&gpio3 7 0>;

Thanks for reviewing. The second round is out.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2014-05-09  6:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 13:31 [PATCH] i.MX25 dts updates Sascha Hauer
2014-05-07 13:31 ` [PATCH 1/6] ARM: dts: i.MX25: Add mmc aliases Sascha Hauer
2014-05-07 14:46   ` Fabio Estevam
2014-05-08  8:04     ` Sascha Hauer
2014-05-08  8:24       ` Shawn Guo
2014-05-07 13:31 ` [PATCH 2/6] ARM: dts: i.MX25: remove disabled property of usbmisc unit Sascha Hauer
2014-05-07 13:31 ` [PATCH 3/6] ARM: dts: i.MX25: Add IRAM node Sascha Hauer
2014-05-07 13:31 ` [PATCH 4/6] ARM: dts: Karo TX25: Add pinctrl nodes Sascha Hauer
2014-05-07 13:31 ` [PATCH 5/6] ARM: dts: Karo TX25: Add phy reset gpio and supply for FEC Sascha Hauer
2014-05-08 12:27   ` Lothar Waßmann
2014-05-09  6:11     ` Sascha Hauer [this message]
2014-05-07 13:31 ` [PATCH 6/6] ARM: dts: Karo TX25: use hardware ecc Sascha Hauer
  -- strict thread matches above, loose matches on Subject: below --
2014-05-09  6:11 [PATCH v2] i.MX25 dts updates Sascha Hauer
2014-05-09  6:11 ` [PATCH 5/6] ARM: dts: Karo TX25: Add phy reset gpio and supply for FEC Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140509061158.GP5858@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).