public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] input: Add new sun4i-ts driver for Allwinner sunxi SoC's rtp controller
Date: Sat, 10 May 2014 07:24:39 -0500	[thread overview]
Message-ID: <20140510122439.GJ7047@lukather> (raw)
In-Reply-To: <1399718826-16215-2-git-send-email-hdegoede@redhat.com>

Hi Hans,

Thanks a lot for reposting this.

On Sat, May 10, 2014 at 12:47:05PM +0200, Hans de Goede wrote:
> Note the sun4i-ts controller is capable of detecting a second touch, but when
> a second touch is present then the accuracy becomes so bad the reported touch
> location is not useable.
> 
> The original android driver contains some complicated heuristics using the
> aprox. distance between the 2 touches to see if the user is making a pinch
> open / close movement, and then reports emulated multi-touch events around
> the last touch coordinate (as the dual-touch coordinates are worthless).
> 
> These kinds of heuristics are just asking for trouble (and don't belong
> in the kernel). So this driver offers straight forward, reliable single
> touch functionality only.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  .../bindings/input/touchscreen/sun4i.txt           |  15 ++
>  drivers/input/touchscreen/Kconfig                  |  10 +
>  drivers/input/touchscreen/Makefile                 |   1 +
>  drivers/input/touchscreen/sun4i-ts.c               | 262 +++++++++++++++++++++
>  4 files changed, 288 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/sun4i.txt
>  create mode 100644 drivers/input/touchscreen/sun4i-ts.c
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt b/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt
> new file mode 100644
> index 0000000..e45927e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt
> @@ -0,0 +1,15 @@
> +sun4i resistive touchscreen controller
> +--------------------------------------
> +
> +Required properties:
> + - compatible: "allwinner,sun4i-ts"

In between, I changed the compatible of this driver to sun4i-a10-ts to
match the pattern used everywhere else. You should probably update it
in your driver as well :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140510/a1d4ffc8/attachment.sig>

  reply	other threads:[~2014-05-10 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-10 10:47 [PATCH resend 0/2] input: Add new sun4i-ts driver for Allwinner sunxi SoCs Hans de Goede
2014-05-10 10:47 ` [PATCH v3 1/2] input: Add new sun4i-ts driver for Allwinner sunxi SoC's rtp controller Hans de Goede
2014-05-10 12:24   ` Maxime Ripard [this message]
2014-05-10 10:47 ` [PATCH v3 2/2] input: sun4i-ts: Add support for temperature sensor Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140510122439.GJ7047@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox