From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: i.MX6 USB OTG support is broken on linux-next
Date: Mon, 12 May 2014 07:45:49 +0200 [thread overview]
Message-ID: <20140512054549.GC5858@pengutronix.de> (raw)
In-Reply-To: <20140510135737.GA1878@shlinux1.ap.freescale.net>
On Sat, May 10, 2014 at 09:57:39PM +0800, Li Jun wrote:
> On Sat, May 10, 2014 at 09:18:36PM +0800, Shawn Guo wrote:
> > + Robin and David,
> >
> > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> > index cb8e991..9081757 100644
> > --- a/drivers/usb/core/Kconfig
> > +++ b/drivers/usb/core/Kconfig
> > @@ -65,7 +65,6 @@ config USB_OTG
> > config USB_OTG_WHITELIST
> > bool "Rely on OTG Targeted Peripherals List"
> > depends on USB_OTG || EXPERT
> > - default y if USB_OTG
> > help
> > If you say Y here, the "otg_whitelist.h" file will be used as a
> > product whitelist, so USB peripherals not listed there will be
> >
> > Shawn
> As Peter suggested, do not enable OTG_FSM in defconfig since there are very few
> HNP&SRP capable device in market. With OTG_FSM enabled, even USB_OTG_WHITELIST
> is not selected, the OTG port still can't work the same as before if you connect
> a normal usb device to it.
If a device is not HNP/SRP capable then it should not be used on this
device. If we can't detect this during runtime then there should be some
devicetree property for that. Making such decisions during compile time
is not an option in the days of multimachine kernels.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-05-12 5:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 13:00 i.MX6 USB OTG support is broken on linux-next Shawn Guo
2014-05-10 11:10 ` Peter Chen
2014-05-10 13:18 ` Shawn Guo
2014-05-10 13:57 ` Li Jun
2014-05-11 1:34 ` Shawn Guo
2014-05-12 5:45 ` Sascha Hauer [this message]
2014-05-13 0:33 ` Peter Chen
2014-05-13 5:48 ` Sascha Hauer
2014-05-11 0:40 ` Peter Chen
2014-05-11 1:40 ` Shawn Guo
2014-05-12 1:22 ` Peter Chen
2014-05-12 13:54 ` Shawn Guo
2014-05-13 0:25 ` Peter Chen
2014-05-13 1:42 ` Shawn Guo
2014-05-13 1:10 ` Li Jun
2014-05-13 2:40 ` Shawn Guo
2014-05-13 2:40 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512054549.GC5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).