[PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

[PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

[Laurent Pinchart]

Hello,

This patch set enables rate propagation from the OMAP3 ISP functional clock to
the DPLL4 M5 clock. It copies Tomi Valkeinen's similar patch set for the OMAP
DSS functional clock from the "OMAP: OMAP3 DSS related clock patches" patch
series.

Laurent Pinchart (2):
  ARM: dts: use ti,fixed-factor-clock for dpll4_m5x2_mul_ck
  ARM: dts: set 'ti,set-rate-parent' for dpll4_m5 path

 arch/arm/boot/dts/omap36xx-clocks.dtsi | 2 +-
 arch/arm/boot/dts/omap3xxx-clocks.dtsi | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

-- 
Regards,

Laurent Pinchart

[PATCH 1/2] ARM: dts: use ti, fixed-factor-clock for dpll4_m5x2_mul_ck

[Laurent Pinchart]

We need to use set-rate-parent for dpll4_m5 clock path, so use the
ti,fixed-factor-clock version which supports set-rate-parent property.

The set-rate-parent flag itself is set in the following patch, this one
just changes the clock driver to ti,fixed-factor-clock without any other
changes.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 arch/arm/boot/dts/omap36xx-clocks.dtsi | 2 +-
 arch/arm/boot/dts/omap3xxx-clocks.dtsi | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/omap36xx-clocks.dtsi b/arch/arm/boot/dts/omap36xx-clocks.dtsi
index 6b5280d..200ae3a 100644
--- a/arch/arm/boot/dts/omap36xx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap36xx-clocks.dtsi
@@ -83,7 +83,7 @@
 };
 
 &dpll4_m5x2_mul_ck {
-	clock-mult = <1>;
+	ti,clock-mult = <1>;
 };
 
 &dpll4_m6x2_mul_ck {
diff --git a/arch/arm/boot/dts/omap3xxx-clocks.dtsi b/arch/arm/boot/dts/omap3xxx-clocks.dtsi
index 12be2b3..351f58b 100644
--- a/arch/arm/boot/dts/omap3xxx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap3xxx-clocks.dtsi
@@ -453,10 +453,10 @@
 
 	dpll4_m5x2_mul_ck: dpll4_m5x2_mul_ck {
 		#clock-cells = <0>;
-		compatible = "fixed-factor-clock";
+		compatible = "ti,fixed-factor-clock";
 		clocks = <&dpll4_m5_ck>;
-		clock-mult = <2>;
-		clock-div = <1>;
+		ti,clock-mult = <2>;
+		ti,clock-div = <1>;
 	};
 
 	dpll4_m5x2_ck: dpll4_m5x2_ck {
-- 
1.8.3.2

[PATCH 2/2] ARM: dts: set 'ti,set-rate-parent' for dpll4_m5 path

[Laurent Pinchart]

Set 'ti,set-rate-parent' property for the dpll4_m5x2_mul_ck clock, which
is used for the ISP functional clock. This fixes the OMAP3 ISP driver's
clock rate configuration, which needs the rate to be propagated properly
to the divider node (dpll4_m5_ck).

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 arch/arm/boot/dts/omap3xxx-clocks.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap3xxx-clocks.dtsi b/arch/arm/boot/dts/omap3xxx-clocks.dtsi
index 351f58b..e47ff69 100644
--- a/arch/arm/boot/dts/omap3xxx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap3xxx-clocks.dtsi
@@ -457,6 +457,7 @@
 		clocks = <&dpll4_m5_ck>;
 		ti,clock-mult = <2>;
 		ti,clock-div = <1>;
+		ti,set-rate-parent;
 	};
 
 	dpll4_m5x2_ck: dpll4_m5x2_ck {
-- 
1.8.3.2

[PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

[Tomi Valkeinen]

On 21/04/14 13:41, Laurent Pinchart wrote:
> Hello,
> 
> This patch set enables rate propagation from the OMAP3 ISP functional clock to
> the DPLL4 M5 clock. It copies Tomi Valkeinen's similar patch set for the OMAP
> DSS functional clock from the "OMAP: OMAP3 DSS related clock patches" patch
> series.
> 
> Laurent Pinchart (2):
>   ARM: dts: use ti,fixed-factor-clock for dpll4_m5x2_mul_ck
>   ARM: dts: set 'ti,set-rate-parent' for dpll4_m5 path
> 
>  arch/arm/boot/dts/omap36xx-clocks.dtsi | 2 +-
>  arch/arm/boot/dts/omap3xxx-clocks.dtsi | 7 ++++---
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 

These look fine to me.

Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140508/209bba74/attachment.sig>

[PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

[Laurent Pinchart]

On Thursday 08 May 2014 13:57:15 Tomi Valkeinen wrote:
> On 21/04/14 13:41, Laurent Pinchart wrote:
> > Hello,
> > 
> > This patch set enables rate propagation from the OMAP3 ISP functional
> > clock to the DPLL4 M5 clock. It copies Tomi Valkeinen's similar patch set
> > for the OMAP DSS functional clock from the "OMAP: OMAP3 DSS related clock
> > patches" patch series.
> > 
> > Laurent Pinchart (2):
> >   ARM: dts: use ti,fixed-factor-clock for dpll4_m5x2_mul_ck
> >   ARM: dts: set 'ti,set-rate-parent' for dpll4_m5 path
> >  
> >  arch/arm/boot/dts/omap36xx-clocks.dtsi | 2 +-
> >  arch/arm/boot/dts/omap3xxx-clocks.dtsi | 7 ++++---
> >  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> These look fine to me.
> 
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

Thank you.

Tony, could you please pick the patches up for v3.16 ?

-- 
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140513/642baaf5/attachment.sig>

[PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

[Tony Lindgren]

* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [140512 16:17]:
> On Thursday 08 May 2014 13:57:15 Tomi Valkeinen wrote:
> > On 21/04/14 13:41, Laurent Pinchart wrote:
> > > Hello,
> > > 
> > > This patch set enables rate propagation from the OMAP3 ISP functional
> > > clock to the DPLL4 M5 clock. It copies Tomi Valkeinen's similar patch set
> > > for the OMAP DSS functional clock from the "OMAP: OMAP3 DSS related clock
> > > patches" patch series.
> > > 
> > > Laurent Pinchart (2):
> > >   ARM: dts: use ti,fixed-factor-clock for dpll4_m5x2_mul_ck
> > >   ARM: dts: set 'ti,set-rate-parent' for dpll4_m5 path
> > >  
> > >  arch/arm/boot/dts/omap36xx-clocks.dtsi | 2 +-
> > >  arch/arm/boot/dts/omap3xxx-clocks.dtsi | 7 ++++---
> > >  2 files changed, 5 insertions(+), 4 deletions(-)
> > 
> > These look fine to me.
> > 
> > Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> 
> Thank you.
> 
> Tony, could you please pick the patches up for v3.16 ?

I'd like to see acks from Tero on these two, or Tero queue
them along with other clock dts clock changes.

Regards,

Tony

[PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

[Laurent Pinchart]

On Monday 12 May 2014 18:06:10 Tony Lindgren wrote:
> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [140512 16:17]:
> > On Thursday 08 May 2014 13:57:15 Tomi Valkeinen wrote:
> > > On 21/04/14 13:41, Laurent Pinchart wrote:
> > > > Hello,
> > > > 
> > > > This patch set enables rate propagation from the OMAP3 ISP functional
> > > > clock to the DPLL4 M5 clock. It copies Tomi Valkeinen's similar patch
> > > > set for the OMAP DSS functional clock from the "OMAP: OMAP3 DSS
> > > > related clock patches" patch series.
> > > > 
> > > > Laurent Pinchart (2):
> > > >   ARM: dts: use ti,fixed-factor-clock for dpll4_m5x2_mul_ck
> > > >   ARM: dts: set 'ti,set-rate-parent' for dpll4_m5 path
> > > >  
> > > >  arch/arm/boot/dts/omap36xx-clocks.dtsi | 2 +-
> > > >  arch/arm/boot/dts/omap3xxx-clocks.dtsi | 7 ++++---
> > > >  2 files changed, 5 insertions(+), 4 deletions(-)
> > > 
> > > These look fine to me.
> > > 
> > > Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > 
> > Thank you.
> > 
> > Tony, could you please pick the patches up for v3.16 ?
> 
> I'd like to see acks from Tero on these two, or Tero queue
> them along with other clock dts clock changes.

I'm fine with Tero queuing the patches in his tree. Tero, could they go in 
v3.16 ?

-- 
Regards,

Laurent Pinchart

[PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

[Tero Kristo]

On 05/15/2014 06:53 PM, Laurent Pinchart wrote:
> On Monday 12 May 2014 18:06:10 Tony Lindgren wrote:
>> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [140512 16:17]:
>>> On Thursday 08 May 2014 13:57:15 Tomi Valkeinen wrote:
>>>> On 21/04/14 13:41, Laurent Pinchart wrote:
>>>>> Hello,
>>>>>
>>>>> This patch set enables rate propagation from the OMAP3 ISP functional
>>>>> clock to the DPLL4 M5 clock. It copies Tomi Valkeinen's similar patch
>>>>> set for the OMAP DSS functional clock from the "OMAP: OMAP3 DSS
>>>>> related clock patches" patch series.
>>>>>
>>>>> Laurent Pinchart (2):
>>>>>    ARM: dts: use ti,fixed-factor-clock for dpll4_m5x2_mul_ck
>>>>>    ARM: dts: set 'ti,set-rate-parent' for dpll4_m5 path
>>>>>
>>>>>   arch/arm/boot/dts/omap36xx-clocks.dtsi | 2 +-
>>>>>   arch/arm/boot/dts/omap3xxx-clocks.dtsi | 7 ++++---
>>>>>   2 files changed, 5 insertions(+), 4 deletions(-)
>>>>
>>>> These look fine to me.
>>>>
>>>> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>>
>>> Thank you.
>>>
>>> Tony, could you please pick the patches up for v3.16 ?
>>
>> I'd like to see acks from Tero on these two, or Tero queue
>> them along with other clock dts clock changes.
>
> I'm fine with Tero queuing the patches in his tree. Tero, could they go in
> v3.16 ?
>

Yeah, am fine with these, I'll queue these in my branch once I have 
those setup.

-Tero

[PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

[Tero Kristo]

On 05/15/2014 06:54 PM, Tero Kristo wrote:
> On 05/15/2014 06:53 PM, Laurent Pinchart wrote:
>> On Monday 12 May 2014 18:06:10 Tony Lindgren wrote:
>>> * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [140512 16:17]:
>>>> On Thursday 08 May 2014 13:57:15 Tomi Valkeinen wrote:
>>>>> On 21/04/14 13:41, Laurent Pinchart wrote:
>>>>>> Hello,
>>>>>>
>>>>>> This patch set enables rate propagation from the OMAP3 ISP functional
>>>>>> clock to the DPLL4 M5 clock. It copies Tomi Valkeinen's similar patch
>>>>>> set for the OMAP DSS functional clock from the "OMAP: OMAP3 DSS
>>>>>> related clock patches" patch series.
>>>>>>
>>>>>> Laurent Pinchart (2):
>>>>>>    ARM: dts: use ti,fixed-factor-clock for dpll4_m5x2_mul_ck
>>>>>>    ARM: dts: set 'ti,set-rate-parent' for dpll4_m5 path
>>>>>>
>>>>>>   arch/arm/boot/dts/omap36xx-clocks.dtsi | 2 +-
>>>>>>   arch/arm/boot/dts/omap3xxx-clocks.dtsi | 7 ++++---
>>>>>>   2 files changed, 5 insertions(+), 4 deletions(-)
>>>>>
>>>>> These look fine to me.
>>>>>
>>>>> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>>>
>>>> Thank you.
>>>>
>>>> Tony, could you please pick the patches up for v3.16 ?
>>>
>>> I'd like to see acks from Tero on these two, or Tero queue
>>> them along with other clock dts clock changes.
>>
>> I'm fine with Tero queuing the patches in his tree. Tero, could they
>> go in
>> v3.16 ?
>>
>
> Yeah, am fine with these, I'll queue these in my branch once I have
> those setup.

Just to let you know, I have now queued these patches in my branch for 
3.16/clk-dt.

-Tero