From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8] usb: xhci: avoid warning for !PM_SLEEP
Date: Tue, 13 May 2014 10:28:29 -0500 [thread overview]
Message-ID: <20140513152829.GK1151@saruman.home> (raw)
In-Reply-To: <1399557141-1346645-7-git-send-email-arnd@arndb.de>
On Thu, May 08, 2014 at 03:52:19PM +0200, Arnd Bergmann wrote:
> If we build a kernel with PM_SUSPEND set and no PM_SLEEP,
> we get a build warning in the xhci-plat driver about unused
> functions.
>
> To fix this, use "#ifdef CONFIG_PM_SLEEP", like we do in most
> other drivers nowadays.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> ---
> drivers/usb/host/xhci-plat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 151901c..3473296 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -202,7 +202,7 @@ static int xhci_plat_remove(struct platform_device *dev)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
can we just drop the ifdeferry altogether, including from SET_*_OPS
macros ? This is just ridiculous that every merge window we have tens of
patches fixing the ifdef in several drivers.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140513/68b44c72/attachment.sig>
next prev parent reply other threads:[~2014-05-13 15:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:52 [PATCH 0/8] usb: various fixes for ARM randconfig failures Arnd Bergmann
2014-05-08 13:52 ` [PATCH 1/8] usb/gadget: s3c2410_udc: don't use pr_debug return value Arnd Bergmann
2014-05-08 13:52 ` [PATCH 2/8] usb: musb: tusb-dma can't be built-in if tusb is not Arnd Bergmann
2014-05-08 13:52 ` [PATCH 3/8] usb: musb: omap2plus bus glue needs USB host support Arnd Bergmann
2014-05-08 13:52 ` [PATCH 4/8] usb: phy: fix isp1301-omap dependency on tps65010 Arnd Bergmann
2014-05-13 15:26 ` Felipe Balbi
2014-05-13 19:48 ` Arnd Bergmann
2014-05-13 19:52 ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 5/8] usb: phy: msm: reset controller is mandatory now Arnd Bergmann
2014-05-08 14:21 ` Ivan T. Ivanov
2014-05-08 14:27 ` Arnd Bergmann
2014-05-08 14:58 ` Ivan T. Ivanov
2014-05-13 15:27 ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 6/8] usb: xhci: avoid warning for !PM_SLEEP Arnd Bergmann
2014-05-13 15:28 ` Felipe Balbi [this message]
2014-05-13 19:39 ` Arnd Bergmann
2014-05-13 19:52 ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 7/8] usb: ohci: sort out dependencies for lpc32xx and omap Arnd Bergmann
2014-05-08 15:51 ` Alan Stern
2014-05-08 13:52 ` [PATCH 8/8] usb: ohci-da8xx can only be built-in Arnd Bergmann
2014-05-08 15:47 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513152829.GK1151@saruman.home \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).