From mboxrd@z Thu Jan 1 00:00:00 1970 From: mturquette@linaro.org (Mike Turquette) Date: Tue, 13 May 2014 17:51:19 -0700 Subject: [PATCH v3 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support In-Reply-To: <1399633911-7094-6-git-send-email-boris.brezillon@free-electrons.com> References: <1399633911-7094-1-git-send-email-boris.brezillon@free-electrons.com> <1399633911-7094-6-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <20140514005119.16152.19787@quantum> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Boris BREZILLON (2014-05-09 04:11:49) > +struct clk_ops ar100_ops = { > + .recalc_rate = ar100_recalc_rate, > + .determine_rate = ar100_determine_rate, > + .set_parent = ar100_set_parent, > + .get_parent = ar100_get_parent, > + .set_rate = ar100_set_rate, > +}; I might be having a brain fart, but is there a valid case for having both a .recalc_rate and a .determine_rate? I believe that the former will never be used and the latter will always be used by the clock framework core. Regards, Mike