From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: davinci: remove checks for CONFIG_USB_MUSB_PERIPHERAL
Date: Thu, 15 May 2014 09:53:56 -0500 [thread overview]
Message-ID: <20140515145356.GA7360@saruman.home> (raw)
In-Reply-To: <1400149025.20469.22.camel@x220>
On Thu, May 15, 2014 at 12:17:05PM +0200, Paul Bolle wrote:
> The Kconfig symbol USB_MUSB_PERIPHERAL was removed in v3.1. The last two
> checks for its macro now always evaluate to false. So remove these
> checks.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> Eyeball tested only.
>
> This is just a straightforward cleanup. It does remove a comment. Is
> that comment still useful? Anyhow, I do wonder whether a proper fix is
> possible here. Perhaps Greg or Felipe knows: it is their commit
> 622859634a66 ("usb: musb: drop a gigantic amount of ifdeferry") that
> removed USB_MUSB_PERIPHERAL. On the other hand I noticed that config
> USB_MUSB_DAVINCI depends on BROKEN. So maybe properly fixing just this
> small problem doesn't buy us much.
>
> arch/arm/mach-davinci/board-dm355-evm.c | 4 ----
> arch/arm/mach-davinci/board-dm355-leopard.c | 4 ----
> 2 files changed, 8 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
> index ecdc7d44fa70..06d63d5651f3 100644
> --- a/arch/arm/mach-davinci/board-dm355-evm.c
> +++ b/arch/arm/mach-davinci/board-dm355-evm.c
> @@ -350,11 +350,7 @@ static struct davinci_mmc_config dm355evm_mmc_config = {
> * you have proper Mini-B or Mini-A cables (or Mini-A adapters)
> * the ID pin won't need any help.
> */
> -#ifdef CONFIG_USB_MUSB_PERIPHERAL
> -#define USB_ID_VALUE 0 /* ID pulled high; *should* float */
> -#else
> #define USB_ID_VALUE 1 /* ID pulled low */
> -#endif
>
> static struct spi_eeprom at25640a = {
> .byte_len = SZ_64K / 8,
> diff --git a/arch/arm/mach-davinci/board-dm355-leopard.c b/arch/arm/mach-davinci/board-dm355-leopard.c
> index 43bacbf15314..680a7a2d9102 100644
> --- a/arch/arm/mach-davinci/board-dm355-leopard.c
> +++ b/arch/arm/mach-davinci/board-dm355-leopard.c
> @@ -208,11 +208,7 @@ static struct davinci_mmc_config dm355leopard_mmc_config = {
> * you have proper Mini-B or Mini-A cables (or Mini-A adapters)
> * the ID pin won't need any help.
> */
> -#ifdef CONFIG_USB_MUSB_PERIPHERAL
> -#define USB_ID_VALUE 0 /* ID pulled high; *should* float */
> -#else
> #define USB_ID_VALUE 1 /* ID pulled low */
> -#endif
>
> static struct spi_eeprom at25640a = {
> .byte_len = SZ_64K / 8,
> --
> 1.9.0
>
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140515/6dd2fd70/attachment.sig>
prev parent reply other threads:[~2014-05-15 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 10:17 [PATCH] ARM: davinci: remove checks for CONFIG_USB_MUSB_PERIPHERAL Paul Bolle
2014-05-15 10:25 ` Sekhar Nori
2014-05-15 14:53 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515145356.GA7360@saruman.home \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).