[PATCH] ARM: imx: clean up error handling

[dan.carpenter@oracle.com (Dan Carpenter)]

On Thu, May 15, 2014 at 09:24:30PM +0200, Emil Goode wrote:
> If we fail to allocate struct platform_device pdev we
> dereference it after the goto label err.
> 
> I have rearranged the error handling a bit to fix the issue
> and also make it more clear.
> 
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
>  arch/arm/mach-imx/devices/platform-ipu-core.c |   22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/devices/platform-ipu-core.c b/arch/arm/mach-imx/devices/platform-ipu-core.c
> index fc4dd7c..14d61d9 100644
> --- a/arch/arm/mach-imx/devices/platform-ipu-core.c
> +++ b/arch/arm/mach-imx/devices/platform-ipu-core.c
> @@ -77,34 +77,38 @@ struct platform_device *__init imx_alloc_mx3_camera(
>  
>  	pdev = platform_device_alloc("mx3-camera", 0);
>  	if (!pdev)
> -		goto err;
> +		return ERR_PTR(ret);

It's more readable to say "return ERR_PTR(-ENOMEM);".

This patch is great but the subject should say "fix" and not "clean up"
since it fixes a NULL dereference bug.  The people who call their
checkpatch.pl clean ups "fixes" are also doing it wrong but those are
newbies and not worth educating.

regards,
dan carpenter