* [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740
@ 2014-05-11 23:10 Magnus Damm
2014-05-12 7:42 ` Geert Uytterhoeven
0 siblings, 1 reply; 8+ messages in thread
From: Magnus Damm @ 2014-05-11 23:10 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm+renesas@opensource.se>
Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM
and CPUIdle in case of C-code less board support for r8a7740.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
Applies on top of renesas-devel-v3.15-rc5-20140511
arch/arm/mach-shmobile/setup-r8a7740.c | 1 +
1 file changed, 1 insertion(+)
--- 0003/arch/arm/mach-shmobile/setup-r8a7740.c
+++ work/arch/arm/mach-shmobile/setup-r8a7740.c 2014-04-24 17:55:06.000000000 +0900
@@ -927,6 +927,7 @@ DT_MACHINE_START(R8A7740_DT, "Generic R8
.init_early = shmobile_init_delay,
.init_irq = r8a7740_init_irq_of,
.init_machine = r8a7740_generic_init,
+ .init_late = shmobile_init_late,
.dt_compat = r8a7740_boards_compat_dt,
MACHINE_END
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740
2014-05-11 23:10 [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740 Magnus Damm
@ 2014-05-12 7:42 ` Geert Uytterhoeven
2014-05-13 8:10 ` Simon Horman
0 siblings, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2014-05-12 7:42 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 12, 2014 at 1:10 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM
> and CPUIdle in case of C-code less board support for r8a7740.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740
2014-05-12 7:42 ` Geert Uytterhoeven
@ 2014-05-13 8:10 ` Simon Horman
2014-05-16 4:08 ` Simon Horman
0 siblings, 1 reply; 8+ messages in thread
From: Simon Horman @ 2014-05-13 8:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 12, 2014 at 09:42:15AM +0200, Geert Uytterhoeven wrote:
> On Mon, May 12, 2014 at 1:10 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > From: Magnus Damm <damm+renesas@opensource.se>
> >
> > Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM
> > and CPUIdle in case of C-code less board support for r8a7740.
> >
> > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks, I will queue this up.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740
2014-05-13 8:10 ` Simon Horman
@ 2014-05-16 4:08 ` Simon Horman
2014-05-16 4:39 ` Magnus Damm
0 siblings, 1 reply; 8+ messages in thread
From: Simon Horman @ 2014-05-16 4:08 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 13, 2014 at 05:10:20PM +0900, Simon Horman wrote:
> On Mon, May 12, 2014 at 09:42:15AM +0200, Geert Uytterhoeven wrote:
> > On Mon, May 12, 2014 at 1:10 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> > > From: Magnus Damm <damm+renesas@opensource.se>
> > >
> > > Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM
> > > and CPUIdle in case of C-code less board support for r8a7740.
> > >
> > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> >
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Thanks, I will queue this up.
Hi Magnus, Hi Geert,
As I am currently doing some work for the r8a7779
I am wondering if a change like this one is appropriate for that SoC.
If so I'll cook one up.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740
2014-05-16 4:08 ` Simon Horman
@ 2014-05-16 4:39 ` Magnus Damm
2014-05-16 4:45 ` Simon Horman
0 siblings, 1 reply; 8+ messages in thread
From: Magnus Damm @ 2014-05-16 4:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Fri, May 16, 2014 at 1:08 PM, Simon Horman <horms@verge.net.au> wrote:
> On Tue, May 13, 2014 at 05:10:20PM +0900, Simon Horman wrote:
>> On Mon, May 12, 2014 at 09:42:15AM +0200, Geert Uytterhoeven wrote:
>> > On Mon, May 12, 2014 at 1:10 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> > > From: Magnus Damm <damm+renesas@opensource.se>
>> > >
>> > > Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM
>> > > and CPUIdle in case of C-code less board support for r8a7740.
>> > >
>> > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>> >
>> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>
>> Thanks, I will queue this up.
>
> Hi Magnus, Hi Geert,
>
> As I am currently doing some work for the r8a7779
> I am wondering if a change like this one is appropriate for that SoC.
> If so I'll cook one up.
Yes, we want all SoCs to be converted over. Please take care that some
DTS change may be needed to specify maximum frequency, so this may
require a DTB update for the user. Which makes it less nice user
experience for legacy code - if we care about that at this point. But
legacy code also often tends to use early devices and other stuff, so
this probably affects DT SoC code and DT reference board code mostly.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740
2014-05-16 4:39 ` Magnus Damm
@ 2014-05-16 4:45 ` Simon Horman
2014-05-16 4:48 ` Magnus Damm
0 siblings, 1 reply; 8+ messages in thread
From: Simon Horman @ 2014-05-16 4:45 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 16, 2014 at 01:39:11PM +0900, Magnus Damm wrote:
> Hi Simon,
>
> On Fri, May 16, 2014 at 1:08 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Tue, May 13, 2014 at 05:10:20PM +0900, Simon Horman wrote:
> >> On Mon, May 12, 2014 at 09:42:15AM +0200, Geert Uytterhoeven wrote:
> >> > On Mon, May 12, 2014 at 1:10 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> >> > > From: Magnus Damm <damm+renesas@opensource.se>
> >> > >
> >> > > Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM
> >> > > and CPUIdle in case of C-code less board support for r8a7740.
> >> > >
> >> > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> >> >
> >> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >>
> >> Thanks, I will queue this up.
> >
> > Hi Magnus, Hi Geert,
> >
> > As I am currently doing some work for the r8a7779
> > I am wondering if a change like this one is appropriate for that SoC.
> > If so I'll cook one up.
>
> Yes, we want all SoCs to be converted over. Please take care that some
> DTS change may be needed to specify maximum frequency, so this may
> require a DTB update for the user. Which makes it less nice user
> experience for legacy code - if we care about that at this point. But
> legacy code also often tends to use early devices and other stuff, so
> this probably affects DT SoC code and DT reference board code mostly.
Does CPU frequency affect this patch (shmobile_init_late) as
well as the ones to use shmobile_init_delay?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740
2014-05-16 4:45 ` Simon Horman
@ 2014-05-16 4:48 ` Magnus Damm
2014-05-16 6:13 ` Simon Horman
0 siblings, 1 reply; 8+ messages in thread
From: Magnus Damm @ 2014-05-16 4:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Fri, May 16, 2014 at 1:45 PM, Simon Horman <horms@verge.net.au> wrote:
> On Fri, May 16, 2014 at 01:39:11PM +0900, Magnus Damm wrote:
>> Hi Simon,
>>
>> On Fri, May 16, 2014 at 1:08 PM, Simon Horman <horms@verge.net.au> wrote:
>> > On Tue, May 13, 2014 at 05:10:20PM +0900, Simon Horman wrote:
>> >> On Mon, May 12, 2014 at 09:42:15AM +0200, Geert Uytterhoeven wrote:
>> >> > On Mon, May 12, 2014 at 1:10 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> >> > > From: Magnus Damm <damm+renesas@opensource.se>
>> >> > >
>> >> > > Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM
>> >> > > and CPUIdle in case of C-code less board support for r8a7740.
>> >> > >
>> >> > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>> >> >
>> >> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> >>
>> >> Thanks, I will queue this up.
>> >
>> > Hi Magnus, Hi Geert,
>> >
>> > As I am currently doing some work for the r8a7779
>> > I am wondering if a change like this one is appropriate for that SoC.
>> > If so I'll cook one up.
>>
>> Yes, we want all SoCs to be converted over. Please take care that some
>> DTS change may be needed to specify maximum frequency, so this may
>> require a DTB update for the user. Which makes it less nice user
>> experience for legacy code - if we care about that at this point. But
>> legacy code also often tends to use early devices and other stuff, so
>> this probably affects DT SoC code and DT reference board code mostly.
>
> Does CPU frequency affect this patch (shmobile_init_late) as
> well as the ones to use shmobile_init_delay?
Oops, wrong patch from my side. =) Please ignore my comment.
But we still want the SoCs to be converted over.
/ magnus
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740
2014-05-16 4:48 ` Magnus Damm
@ 2014-05-16 6:13 ` Simon Horman
0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2014-05-16 6:13 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 16, 2014 at 01:48:00PM +0900, Magnus Damm wrote:
> Hi Simon,
>
> On Fri, May 16, 2014 at 1:45 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Fri, May 16, 2014 at 01:39:11PM +0900, Magnus Damm wrote:
> >> Hi Simon,
> >>
> >> On Fri, May 16, 2014 at 1:08 PM, Simon Horman <horms@verge.net.au> wrote:
> >> > On Tue, May 13, 2014 at 05:10:20PM +0900, Simon Horman wrote:
> >> >> On Mon, May 12, 2014 at 09:42:15AM +0200, Geert Uytterhoeven wrote:
> >> >> > On Mon, May 12, 2014 at 1:10 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> >> >> > > From: Magnus Damm <damm+renesas@opensource.se>
> >> >> > >
> >> >> > > Hook up ->init_late for r8a7740 to initialize Suspend-to-RAM
> >> >> > > and CPUIdle in case of C-code less board support for r8a7740.
> >> >> > >
> >> >> > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> >> >> >
> >> >> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >> >>
> >> >> Thanks, I will queue this up.
> >> >
> >> > Hi Magnus, Hi Geert,
> >> >
> >> > As I am currently doing some work for the r8a7779
> >> > I am wondering if a change like this one is appropriate for that SoC.
> >> > If so I'll cook one up.
> >>
> >> Yes, we want all SoCs to be converted over. Please take care that some
> >> DTS change may be needed to specify maximum frequency, so this may
> >> require a DTB update for the user. Which makes it less nice user
> >> experience for legacy code - if we care about that at this point. But
> >> legacy code also often tends to use early devices and other stuff, so
> >> this probably affects DT SoC code and DT reference board code mostly.
> >
> > Does CPU frequency affect this patch (shmobile_init_late) as
> > well as the ones to use shmobile_init_delay?
>
> Oops, wrong patch from my side. =) Please ignore my comment.
>
> But we still want the SoCs to be converted over.
Thanks. I'll start with a patch for the r8a7779.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-05-16 6:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-11 23:10 [PATCH] ARM: shmobile: Use shmobile_init_late() on r8a7740 Magnus Damm
2014-05-12 7:42 ` Geert Uytterhoeven
2014-05-13 8:10 ` Simon Horman
2014-05-16 4:08 ` Simon Horman
2014-05-16 4:39 ` Magnus Damm
2014-05-16 4:45 ` Simon Horman
2014-05-16 4:48 ` Magnus Damm
2014-05-16 6:13 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).