linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: remove ARM710 specific assembler code
Date: Mon, 19 May 2014 11:18:49 +0100	[thread overview]
Message-ID: <20140519101848.GG5113@arm.com> (raw)
In-Reply-To: <20140517102638.GQ3693@n2100.arm.linux.org.uk>

On Sat, May 17, 2014 at 11:26:38AM +0100, Russell King - ARM Linux wrote:
> On Sat, May 17, 2014 at 10:56:02AM +0100, Catalin Marinas wrote:
> > > The difference between what you're proposing and what happened to ARMv3
> > > is that ARMv3 was broken for quite some time (we read from some of the
> > > CP15 registers which are read-only in ARMv3) and no one ever raised a
> > > problem with that.  So, after a sufficient period of time, it got removed
> > > - and no one batted an eyelid.  That's the correct way to do it - allow
> > > code to age, and if no one notices it's been broken, then it can be
> > > removed.
> > 
> > I?m more for pro-actively ?breaking? it with a DEPRECATED
> > dependency. For example, if you suspect that some code like ARM710T is
> > no longer in use, we mark it and see if anyone complains about this over
> > a two years period. If not, it gets removed.
> > 
> > Waiting for code to get broken is another way but it?s less
> > predictable.
> 
> When code being used gets broken, it's nice to think that we'll get
> bug reports which will tell us if it's still being used.

But if you don't get any reports, you can't really whether it's broken
(just because it compiles doesn't mean it still works). So we end up
with keeping code in the kernel for much longer than necessary.

> The problem
> with DEPRECATED is that it will get lost amongst all the thousands
> of other config options and won't be noticed.  Just like EXPERIMENTAL
> or any of the other similar options we've had.

DEPRECATED is meant for documenting the planned removal. If people
complain afterwards, it's their problem for not reporting it earlier.

But we can make it even clearer by adding "depends on n" for DEPRECATED
or just making it not user selectable, so that people would need to
actively change the Kconfig source. They can't complain they haven't
noticed.

-- 
Catalin

  reply	other threads:[~2014-05-19 10:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28 21:46 [PATCH] ARM: remove last use of CONFIG_CPU_ARM710 Paul Bolle
2014-05-14  8:24 ` [PATCH] [RESEND] " Paul Bolle
2014-05-14  8:48   ` Alexander Shiyan
2014-05-14  9:07     ` Paul Bolle
2014-05-14  9:17   ` Arnd Bergmann
2014-05-14  9:25     ` Paul Bolle
2014-05-14  9:28       ` Arnd Bergmann
2014-05-16  9:29         ` [PATCH] ARM: remove ARM710 specific assembler code Paul Bolle
2014-05-16 12:55           ` Russell King - ARM Linux
2014-05-16 14:50             ` Paul Bolle
2014-05-17  9:23             ` Catalin Marinas
2014-05-17  9:46               ` Russell King - ARM Linux
2014-05-17  9:56                 ` Catalin Marinas
2014-05-17 10:26                   ` Russell King - ARM Linux
2014-05-19 10:18                     ` Catalin Marinas [this message]
2014-05-19 11:26                   ` Arnd Bergmann
2014-05-20 16:05                     ` Tony Lindgren
2014-05-20 20:09                       ` Arnd Bergmann
2014-05-22 18:40                         ` Tony Lindgren
2014-05-22 18:42                           ` Tony Lindgren
2014-05-20 15:48               ` One Thousand Gnomes
2014-05-20 16:14                 ` Catalin Marinas
2014-05-23  9:07         ` [PATCH] [RESEND] ARM: remove last use of CONFIG_CPU_ARM710 Paul Bolle
2014-05-23  9:22           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140519101848.GG5113@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).